instascan icon indicating copy to clipboard operation
instascan copied to clipboard

Avoid asking for permissions twice

Open optout21 opened this issue 5 years ago • 6 comments

See https://github.com/schmich/instascan/issues/110

No permission asked during getCameras(), option to skip _ensureAccess().

optout21 avatar May 07 '19 10:05 optout21

Does this work? how do I use this new change?

kidanam avatar Jun 23 '19 03:06 kidanam

Yes, double call is avoided with this proposed change. I believe it solves the problems reported in issue #110 .

optout21 avatar Jun 26 '19 22:06 optout21

See #110

No permission asked during getCameras(), option to skip _ensureAccess().

How do I use this in the browser?

Maxwellkurt0407 avatar Jul 07 '20 05:07 Maxwellkurt0407

How do I use this in the browser?

What do you mean? How to use instascan in a browser? It is HTML/web based.

optout21 avatar Jul 07 '20 09:07 optout21

How do I use this in the browser?

What do you mean? How to use instascan in a browser? It is HTML/web based.

Amateur developer here, I apologize. I mean, how do I include the changes in the instascan.min.js file? Is there a way to do that?

Maxwellkurt0407 avatar Jul 08 '20 00:07 Maxwellkurt0407

To integrate the changes for trying out? Since there are only 2-3 lines changed, you can just look at Files Changed, and copy the changes. Or you can checkout the branch of the pr:

git remote add mikroncoin https://github.com/mikroncoin/instascan.git
git fetch mikroncoin
git checkout -b pr/213 -t mikroncoin/no-double-perm

To take over the changes for good, you just Merge the PR :)

optout21 avatar Jul 09 '20 09:07 optout21

Closing after 4+ years

optout21 avatar Feb 13 '23 11:02 optout21