instascan icon indicating copy to clipboard operation
instascan copied to clipboard

[Deprecation] URL.createObjectURL

Open thales-martins opened this issue 5 years ago • 15 comments

URL.createObjectURL with media streams is deprecated and will be removed in M69, around September 2018. Please use HTMLMediaElement.srcObject instead. See https://www.chromestatus.com/features/5618491470118912 for more details.

thales-martins avatar Aug 23 '18 23:08 thales-martins

looks like there is a commit removing this, but no release for it. I think this could be solved just by doing a release build of the master branch.

pmcquay avatar Aug 24 '18 13:08 pmcquay

Found the commit: https://github.com/schmich/instascan/commit/bb59b1e1bd0271d0641ea9663bbad42bab217a96

Luckily, I've somehow managed to patch this error by changing the Minified JavaScript file: https://github.com/LiveG-Technologies/ScanMap/blob/master/src/lib/instascan.min.js

I'm not 100% sure this fixes the problem but no deprecation warnings show so I guess it works! I haven't tested this patch on iOS yet (iOS apparently has this feature removed already).

LiveG-Technologies avatar Sep 02 '18 17:09 LiveG-Technologies

Doesn't work on iOS, but I'm gonna try Chrome on iOS.

LiveG-Technologies avatar Sep 02 '18 17:09 LiveG-Technologies

The deprecated warning has turned into a full blown error and breaks instascan in Firefox, however; this fixes it. Thank you for putting this together!

nnoujaim avatar Sep 12 '18 01:09 nnoujaim

Of course! I guess I made it just in time!

LiveG-Technologies avatar Sep 15 '18 07:09 LiveG-Technologies

Found the commit: bb59b1e

Luckily, I've somehow managed to patch this error by changing the Minified JavaScript file: https://github.com/LiveG-Technologies/ScanMap/blob/master/src/lib/instascan.min.js

I'm not 100% sure this fixes the problem but no deprecation warnings show so I guess it works! I haven't tested this patch on iOS yet (iOS apparently has this feature removed already).

Hey LiveG-Technologies. I'm sure that you don't know how I love you. Now, you know. Thank you so much !!!!!!!

elcitrovmtgrande avatar Sep 19 '18 08:09 elcitrovmtgrande

Hoping this gets fixed before Dec 2018.

d-amit avatar Sep 26 '18 15:09 d-amit

Hoping this gets fixed before Dec 2018.

However, if you are in a cordova you should try this amazing plugin who saved my life : https://github.com/phonegap/phonegap-plugin-barcodescanner

Regards,

elcitrovmtgrande avatar Sep 26 '18 15:09 elcitrovmtgrande

thanks guys!

pinkzomo avatar Oct 01 '18 18:10 pinkzomo

Found the commit: bb59b1e

Luckily, I've somehow managed to patch this error by changing the Minified JavaScript file: https://github.com/LiveG-Technologies/ScanMap/blob/master/src/lib/instascan.min.js

I'm not 100% sure this fixes the problem but no deprecation warnings show so I guess it works! I haven't tested this patch on iOS yet (iOS apparently has this feature removed already).

Hey LiveG-Technologies. I'm sure that you don't know how I love you. Now, you know. Thank you so much !!!!!!!

@elcitrovmtgrande sure thing! No problem. Man I get a lot of appreciation these days! :wink:

(Oops late reply)

LiveG-Technologies avatar Oct 14 '18 10:10 LiveG-Technologies

The above linked file seems to have an issue with camera permissions in firefox. For others who find themselves on this issue I've recreated a minified js file from master with the following steps:

  • clone https://github.com/schmich/instascan
  • run npm i
  • install gulp-cli
  • run gulp release
  • copy dist/instascan.min.js

astroash avatar Nov 13 '18 13:11 astroash

@astroash I guess I need to run npm install also?

Legion112 avatar Dec 07 '18 10:12 Legion112

@Legion112 yup, I missed that step!

astroash avatar Dec 07 '18 11:12 astroash

@astroash really exiting it works with the first try ). Thanks.

Legion112 avatar Dec 07 '18 11:12 Legion112

Found the commit: bb59b1e

Luckily, I've somehow managed to patch this error by changing the Minified JavaScript file: https://github.com/LiveG-Technologies/ScanMap/blob/master/src/lib/instascan.min.js

I'm not 100% sure this fixes the problem but no deprecation warnings show so I guess it works! I haven't tested this patch on iOS yet (iOS apparently has this feature removed already).

OMG, I LOVE YOUUUUUU. I already stressed why it didn't work at all and now violaa~, thank you so much

gzandrk avatar Oct 11 '23 11:10 gzandrk