schlagmichdoch
[Bug] Name not saved permanently
Describe the bug Whenever I change the name it says "Display name is changed permanently" but the next time I use pairdrop.net the name is usually reset to some random name.
I have not actively cleared my cookies or site data or anything in between.
To Reproduce Steps to reproduce the behavior:
- Go to pairdrop.net.
- Edit the name input at the bottom to something specific, press Enter, a message "Display name is changed permanently" appears.
- Wait a week or two.
- Go to pairdrop.net again.
- Note that the name has reverted to something random.
Expected behavior The name should still be the one I set.
Desktop (please complete the following information):
- OS: Windows 10
- Browser: Chrome 130
Bug occurs on official PairDrop instance https://pairdrop.net/ Yes Version: v1.10.10
Additional context
I wonder where this name is stored, it seems to be neither local storage nor a cookie.
This was one of the issues that got buried accidentally when GitHub deleted lots info from this repository. So although we tried to fix this already the testing was never finished.
This was my last response:
About the problem with persistent storage on Google Chrome: Google Chrome has an interesting approach to persistent storage. It will only be persistent if one of the following is true:
- The site is bookmarked (and the user has 5 or less bookmarks)
- The site has high site engagement
- The site has been added to home screen
- The site has push notifications enabled
And only after the script has explicitly asked for permissions.
I implemented this on https://github.com/schlagmichdoch/PairDrop/pull/108
I can try to rebase and improve this implementation onto v2.0 after it is released. Would you be open to testing this?
Oh wow, I did not know this. (I should.) Yes, happy to test this. Will you be hosting the branch somewhere or should I set up a private instance?