PairDrop icon indicating copy to clipboard operation
PairDrop copied to clipboard

[Enhancement] If pairing is successful but connection fails Edit Paired Devices dialog shows `undefined`

Open schlagmichdoch opened this issue 2 years ago • 2 comments

This is due to the signaling server working as expected but the WebRTC connection failing. As the (edited) deviceNames are transferred between the devices only without ever being sent to the server, the Edit Dialog shows "undefined" as long as there hasn't been a successful WebRTC connection.

Probably, we should prefill the IndexedDB with the generated device names though. I'll create a separate issue for that.

Originally posted by @schlagmichdoch in https://github.com/schlagmichdoch/PairDrop/issues/215#issuecomment-1854207589

To include edited device names, the IndexedDB entries for device and display name are only added after there was a successful WebRTC connection between the two devices. The reduce confusion we should prefill the IndexedDB entries with the server generated random names.

schlagmichdoch avatar Dec 13 '23 16:12 schlagmichdoch

It is happening to me too, Pairdrop works on Linux and Android, but for transferring a file to Safari Mac, it pairs but the transfer fails just when it begins.

I tried to install Brave Browser on Mac, but the result is the same.

If there is a solution I did not understand what it is

francuss avatar Jan 14 '24 00:01 francuss

It is happening to me too, Pairdrop works on Linux and Android, but for transferring a file to Safari Mac, it pairs but the transfer fails just when it begins.

I tried to install Brave Browser on Mac, but the result is the same.

If there is a solution I did not understand what it is

Sorry for the late reply, somehow I have missed your comment.

I’m not sure what the problem is, but I believe it is unrelated to this issue. Is the device gone completely after the transfer fails? Then it is probably connected to this issue: #260

schlagmichdoch avatar Feb 02 '24 15:02 schlagmichdoch