tpxo compatibility in different grid longitude formats

[BahramKhazaei-NOAA]

I realized that when I use longitude values in range (-180,180) pyschism generates different bctides.in compared to a case that I use the same grid but with longitudes translated into range (0, 360). That also results in erroneous simulation results by the model (in a 2D tide-only case).

I'm using tpxo as source. My grid covers Alaska and overlaps with dateline.

Just a note that we had discussions about this before and my recollection is that pyschism internally makes the translation to avoid this, but opened this issue to figure out where this error comes from.

[cuill]

@BahramKhazaei-NOAA I tested with Pacific hgrid. Both ranges generated the same bctides. Would you mind sharing your hgrid?

[BahramKhazaei-NOAA]

I'm comparing these two:

(-180, 180) range --> Not working BS_mesh_v1.14_updatedBC.zip

(0, 360) range --> Working BS_mesh_v1.14_updatedBC_0_360.zip

Thank you for your help.

[BahramKhazaei-NOAA]

And here are the bctides and their difference: bctides.zip

[cuill]

@BahramKhazaei-NOAA It looks like the conversion from [0, 360) to [-180, 180) is wrong.

It should be: lon[lon>180] -= 360