Alan Schio

Results 80 comments of Alan Schio

THanks @danielroe , i am tring to see why the compare is failing, looks like it is relative to permisison/fork too, i am investigating that

@danielroe i've tried one hour long all the things to find out why it was not working... even tho i was wondering if it is related to the fork, i...

@danielroe for sure, feel free to play around with it

I did some testing and looks like when changing from `pull_request` to `pull_request_target` works, but the `pull_request_target` must be on the main yml. At my test it does look like...

@danielroe sorry i wrote it wrong, by: > but the pull_request_target must be on the main yml. i mean on the yml of the main branch here https://github.com/nuxt/cli/blob/main/.github/workflows/size.yml at my...

@danielroe i believe is due the `repository: ${{ github.event.pull_request.head.repo.full_name }}` line missing isnot?

Brought back the repo info but continue to failing, nowi am changing to use sha as twk3 said in here https://github.com/twk3/rollup-size-compare-action/issues/273#issuecomment-2622042557

Looks like that: for pull_request_target, it needs: ``` ref: ${{github.event.pull_request.head.ref}} repository: ${{github.event.pull_request.head.repo.full_name}} ``` for pull_request it needs the ref to be ``` ref: ${{github.event.pull_request.head.sha}} ```

@danielroe that is real odd, i cant reason about it anymore :

As you mentioned here https://github.com/nuxt/cli/pull/705#issuecomment-2637253600 there was a check that passed https://github.com/nuxt/cli/actions/runs/13159970893/job/36725939692 I looked upon it and looks like the target commits are: my fork commit 10ca2f250c78139b7dce239c3e07d00946212b0e https://github.com/schirrel/cli/commit/10ca2f250c78139b7dce239c3e07d00946212b0e nuxt/cli commit...