public-transport-enabler icon indicating copy to clipboard operation
public-transport-enabler copied to clipboard

AbstractNavitiaProvider: Remove all providers based on Navitia.

Open schildbach opened this issue 2 years ago • 9 comments

I propose to remove all providers based on Navitia. They have been causing many runtime errors since years, without anyone working on them. If we don't find a responsible maintainer for the Navitia API (mainly AbstractNavitiaProvider), we I think we'd rather remove these classes.

schildbach avatar Sep 17 '21 14:09 schildbach

Pinging @aelkhour and @grote as you're listed as authors.

schildbach avatar Sep 21 '21 09:09 schildbach

Also pinging @ialokim and @prhod about the removal of Navitia from PTE.

grote avatar Sep 21 '21 09:09 grote

I think it's less the PTE's implementation of AbstractNavitiaProvider that leads to problems, but instead the data on the Navitia server which is not always up-to-date or gets some updates changing IDs or such. I think we can not do much on PTE's side on this, apart from perhaps implementing a slightly better error handling.

It would be really a shame if all those providers were removed from PTE. I would be okay maintaining them to the extend that is possible without having access to the data source (Navitia API) itself.

ialokim avatar Sep 21 '21 10:09 ialokim

@schildbach I don't have the bandwidth to maintain this provider. Although I am the instigator of this and had a lot of fun adding it, I understand your decision if there are no maintainers.

aelkhour avatar Sep 21 '21 10:09 aelkhour

The removal of all providers based on Navitia would be a big loss :( What specific errors/problems are encountered with Navitia? I would be happy to help working those out :)

Altonss avatar Oct 14 '21 15:10 Altonss

Thanks @grote for poking me, seems i've missed a few messages, sorry about that. I've relayed the message to the Navitia dev team, I hope a solution can be found on this.

prhod avatar Oct 14 '21 16:10 prhod

Hi all, Here is some reflexions i had this evening

  • Maybe we could post a message to get some help from the navitia forum. But i can't understand what kind of errors we are talking about, and what kind of contributions we need on PTE
  • If errors occurs mostly on few providers (seems to be "coverages" in Navitia API), maybe could you delete only these providers ?
  • @grote told us about some id change problems. As it comes from GTFS providers, you may known some good practise : how do you manage this kind of change with the other providers ? Maybe we could do some improvement in Navitia API on that point ?

stifoon avatar Oct 14 '21 21:10 stifoon

The removal of all providers based on Navitia would be a big loss :( What specific errors/problems are encountered with Navitia? I would be happy to help working those out :)

Sorry for getting back to your question only now.

I tagged most of the open issues with the tag "navitia".

schildbach avatar Mar 14 '22 22:03 schildbach

There is one more problem with Navitia: their API limit for free accounts seems to be exceeded by Öffi now and then. Not sure how other apps like Transportr do, but for Öffi this is quite discouraging.

schildbach avatar Jan 26 '23 13:01 schildbach