laravel-backup
laravel-backup copied to clipboard
schickling
Add Maximum Backups for Amazon S3
Add a new configuration option for users to be able to choose the maximum amount of backups to store in their Amazon S3 bucket. After the maximum amount of backups are stored, the system will properly delete the amount necessary to trim to the maximum, deleting oldest to newest.
Just a note: I didn't write up any extra tests for this functionality. Everything is running just fine on several of my test environments, but I'd obviously recommend writing tests to be 100% sure before merging.
Coverage decreased (-4.92%) when pulling b643701d9d9884048b0c24405984989b111f07c0 on HuisingaWS:master into 4c3285d4efa0155e24b1cf78f4956ffb20dd6a8d on schickling:master.
Hey Aaron,
I'd really love to merge this feature but please also provide some testcases for this!
To be honest I'm terrible with phpunit, but I'll try and get some written up over the weekend. I'm also working on adding maximum local backups as well as gzip support. Those will be different pull requests.
Awesome. It's definitely worth it investing some time in learning test driven development! :+1:
I'm really looking forward to merge the other pull requests!
Coverage decreased (-19.16%) when pulling 4f63fc417c07bbe8ed52050c1a86281b2400e4a6 on aaronhuisinga:master into 4c3285d4efa0155e24b1cf78f4956ffb20dd6a8d on schickling:master.