chromeless icon indicating copy to clipboard operation
chromeless copied to clipboard

fix(package): pins serverless-plugin-chrome to 1.0.0-38 (fix #387)

Open nsfmc opened this issue 7 years ago • 6 comments

This fixes the vague Error: Unknown command: protocol error (#387).

pinned version found via a similar issue report: adieuadieu/serverless-chrome#120

  • [x] Rebase your changes on master so that they can be merged easily
  • [ ] Make sure all tests and linter rules pass

nsfmc avatar Mar 13 '18 23:03 nsfmc

Codecov Report

Merging #415 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #415   +/-   ##
=======================================
  Coverage   38.03%   38.03%           
=======================================
  Files           7        7           
  Lines         844      844           
  Branches      116      116           
=======================================
  Hits          321      321           
  Misses        523      523

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f172e64...6f0e5b4. Read the comment docs.

codecov-io avatar Mar 13 '18 23:03 codecov-io

Do we still need to pin to [email protected] or does the latest version of serverless-plugin-chrome resolve the Error: Unknown command: protocol issue?

adieuadieu avatar Jul 08 '18 16:07 adieuadieu

I just fixed this issue pinning to 1.0.0-38, before I was using the last version of the plugin

ivnaru avatar Jul 12 '18 19:07 ivnaru

@arielmcm were you having the same Error: unknown command: protocol issue until pinning back to 1.0.0-38? if so, this commit should probably be looked at again.

if there's a separate solution (or upstream serverless-plugin-chrome is fixed) i'm happy to close it.

nsfmc avatar Jul 12 '18 19:07 nsfmc

@nsfmc yes, same exact Error: unknown command: protocol error before pining to 1.0.0-38

ivnaru avatar Jul 12 '18 19:07 ivnaru

@adieuadieu would you mind taking another look at this or let me know if you think i should close this pr?

nsfmc avatar Jul 12 '18 19:07 nsfmc