chromeless
chromeless copied to clipboard
add chromeFlags, chromePath and --headless as default
- fixes #146 pdf only works in headless mode
- fixes #184 Add chromePath and chromeFlags to ChromelessOptions
@gorangajic Thank you for this PR. Would you mind adding chromePath
while you're at it? See #184
@adieuadieu you had the most experience with the Chrome part. Please go ahead!
Will chromeFlags support a --no-sandbox
mode? It seems like ArchLinux uses SUID instead of Namespace, which is preventing chrome from launching different instances with unique debugging ports. This would be extremely useful to run tests using chromeless in parallel locally.
@gorangajic do you know if this will allow proxies set in the flags to work on Lambda?
@jborden13 not sure
Codecov Report
Merging #192 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #192 +/- ##
=======================================
Coverage 38.03% 38.03%
=======================================
Files 7 7
Lines 844 844
Branches 116 116
=======================================
Hits 321 321
Misses 523 523
Impacted Files | Coverage Δ | |
---|---|---|
src/api.ts | 47.71% <ø> (ø) |
:arrow_up: |
src/chrome/local.ts | 54.38% <ø> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update fcdc8dc...deb8d40. Read the comment docs.
What is waiting for this to be merged?