WAAS icon indicating copy to clipboard operation
WAAS copied to clipboard

Refactor passing redis around

Open jgorset opened this issue 2 years ago • 1 comments

Re https://github.com/schibsted/WAAS/pull/74#issuecomment-1372165384

Can you take a look at this and tell me what you think @Johannes-Andersen @auduny @3ddyBoi? I'm not totally sure how I feel about it, personally. On the one hand, it's nice to not have to pass the redis connection around to lots of functions, but on the other they now depend on src.database. I think I like it slightly more than I don't like it, but what do you think?

jgorset avatar Jan 05 '23 13:01 jgorset

Sorry about the messy old commits in the PR, had too many things going at once here. Just look at the diff, that's concise.

jgorset avatar Jan 05 '23 13:01 jgorset