Kirk Scheibelhut
Kirk Scheibelhut
> Isn't the current implementation enough so long as all third-party clients are enabled for CORS? What does this entail, some sort of whitelisting? What would I need to do...
> which uses an `iframe` and manual copy pasting to keep the third party server operators from messing with the logins Yeah, that's the whole bit I'm hoping to do...
I have written [`@pkmn/img`](https://github.com/pkmn/ps/tree/master/img) which contains all of the logic required for displaying Pokémon Showdown's sprite and icon resources and handles alternative gens and signficantly more of the sprite edge...
I do not ‘hate it when you review my code’. I think code review is important and would like to make sure that you’re on board with the approach and...
The disagreement lies on what you characterize as legitimate problems. I would like to see what you consider legitimate problems with the current code as it would provide critical insight...
If thats the case, I'm not comfortable moving the code under this repo.
Just disable and fade the buttons?
OK, so I see a couple logical places (not thinking about mobile landscape): 1) below the team: simple, makes use of empty space in the UI, but likely off screen...
`|J|` is the silent one (I made this mistake as well)
Strawman code to illustrate the approach: ```php function search($usera = NULL, $userb = NULL, $format = NULL, $byRating = false, $isPrivate = false, $page = 0) { if (!$this->db) return...