Peter Scheibel

@KiruyaMomochi thanks for reporting the error: I spoke with @johnwparent about [this](https://github.com/spack/spack/pull/30690#issuecomment-1261245311) and I think he is aware of how to fix both issues (he will be pushing a change...

I assigned https://github.com/spack/spack/issues/32404 to myself, which is both Git and caching-related, but FYI that problem is conceptually separate (i.e. I would have very likely resolved that without fixing this, and...

Thanks!

I'm trying to make a list of all the things that we ought to make sure to test. Some of this is going to be covered by leaving older tests...

>> a package defines a builder which defines new phases > Didn't we set on allowing this on a specific class of builders? I'd be fine allowing custom phases on...

At this point `concretize.lp` is sufficiently simple, and https://github.com/spack/spack/pull/27987#discussion_r772711706 proposes a schema structure. So @tgamblin @becker33 if that seems agreeable I can update the schema validation and tests.

This now * Implements the schema discussed in https://github.com/spack/spack/pull/27987#discussion_r779783726 (currently there are examples placed in a `test-cfgs/` directory which will be updated to unit tests * Implements preferences for condition...

@becker33 this appears to be passing unit tests and I have mostly addressed https://github.com/spack/spack/pull/27987#pullrequestreview-845203141 minus a couple issues I have questions about: * I added preference weighting for conditions in...

> My understanding for the semantic is that (please correct me if I am wrong): > Within a single one_of list of constraints, only one of them must hold >...

https://github.com/spack/spack/pull/27987/commits/5e9ee88ab8527bee4927dfaedb355808ee8771cf should address https://github.com/spack/spack/pull/27987#issuecomment-1187487805. I need to add tests and that suggests a worthwhile test to add.