Scott Gray

Today we have the `FDBDatabaseRunner` which can be used to iteratively perform work and to repeatedly run a transaction to success, however for certain tasks the success or failure of...

In locations, such as https://github.com/FoundationDB/fdb-record-layer/blob/2e1b2bc723ee5973e765f7fd35c99226f2330208/fdb-record-layer-lucene/src/main/java/com/apple/foundationdb/record/lucene/directory/FDBDirectory.java#L176, the Lucene index is using `.thenApplyAsync`. In general you don't need (or want) to use thenApplyAsync(). The `CompletableFuture. *Async()` will create a new future that...

WIth https://github.com/FoundationDB/fdb-record-layer/pull/1344, @panghy provided a mechanism by which the `FDBDatabaseFactory` can have alternative implementations. This resulted in some internal build errors in record layer that were addressed in https://github.com/FoundationDB/fdb-record-layer/pull/1384, however...

While reviewing https://github.com/FoundationDB/fdb-record-layer/pull/1309, I noticed that the Lucene index uses `join()` relatively frequently (particularly in `FDBDrectory`). A first note is that, with the exception of tests, Record Layer code should...

OnlineIndexerSimpleTest.testConfigLoader() test failure

2

During a PRB run for https://github.com/FoundationDB/fdb-record-layer/pull/926, this test failed with: ``` org.opentest4j.AssertionFailedError: expected: but was: at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55) at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62) at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:150) at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:145) at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:510) at com.apple.foundationdb.record.provider.foundationdb.OnlineIndexerSimpleTest.testConfigLoader(OnlineIndexerSimpleTest.java:876) ```

org.opentest4j.AssertionFailedError: expected: not at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:36) at org.junit.jupiter.api.Assertions.fail(Assertions.java:62) at org.junit.jupiter.api.AssertNotNull.failNull(AssertNotNull.java:49) at org.junit.jupiter.api.AssertNotNull.assertNotNull(AssertNotNull.java:38) at org.junit.jupiter.api.AssertNotNull.assertNotNull(AssertNotNull.java:33) at org.junit.jupiter.api.Assertions.assertNotNull(Assertions.java:236) at com.apple.foundationdb.record.provider.foundationdb.FDBRecordStoreTest.testVersionStamp(FDBRecordStoreTest.java:1937)

The latest mainline build exits if you hit CTRL-C while a query is running. That's no good

When started in a fresh environment (no $HOME/.jsqsh or sqshrc): java.lang.IndexOutOfBoundsException: Index: 0, Size: 0 at java.util.ArrayList.rangeCheck(ArrayList.java:653) at java.util.ArrayList.get(ArrayList.java:429) at org.jline.reader.impl.LineReaderImpl.insertSecondaryPrompts(LineReaderImpl.java:3442) at org.jline.reader.impl.LineReaderImpl.redisplay(LineReaderImpl.java:3233) at org.jline.reader.impl.LineReaderImpl.cleanup(LineReaderImpl.java:2180) at org.jline.reader.impl.LineReaderImpl.readLine(LineReaderImpl.java:570) at org.jline.reader.impl.LineReaderImpl.readLine(LineReaderImpl.java:400) at...

The following should happen: 1> \set x='"' 2> \echo $x " however, what actually happens is: 1> \set x='"' 2> \echo $x Did not find a matching closing double quote

I think now that with the API's provided by JLine3 to determine things like screen width and the newer java process builder API's that most, if not all, JNI that...