scenery icon indicating copy to clipboard operation
scenery copied to clipboard

Post render functionalities for synchronized animations and texture requests

Open aryaman-gupta opened this issue 4 years ago • 3 comments
trafficstars

Adds capability to insert a user-defined lambda at the end of a render loop, which can be used to create consistent animations that are synchronized with the rendering. PostRenderLambdaExample shows how the functionality can be used. Also adds capability for persistent texture requests which are served once per render frame. These may particularly be useful, e.g, when compute shaders are used and output textures need to be accessed every time they are updated. The PersistentTextureRequestsExample shows how the functionality may be used.

Once @kephale has a look at whether this addresses #395, and @skalarproduktraum has a look at whether the code looks alright, I will add the same functionality to the OpenGLRenderer as well, thereby finalizing the PR.

aryaman-gupta avatar Apr 02 '21 14:04 aryaman-gupta

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Apr 02 '21 14:04 sonarqubecloud[bot]

Codecov Report

Merging #396 (5e9c0d1) into master (63eb65e) will decrease coverage by 32.91%. The diff coverage is 5.28%.

:exclamation: Current head 5e9c0d1 differs from pull request most recent head f544f71. Consider uploading reports for the commit f544f71 to get more accurate results Impacted file tree graph

@@              Coverage Diff              @@
##             master     #396       +/-   ##
=============================================
- Coverage     55.64%   22.72%   -32.91%     
+ Complexity     1967      883     -1084     
=============================================
  Files           169      175        +6     
  Lines         19290    19492      +202     
  Branches       2972     2994       +22     
=============================================
- Hits          10732     4429     -6303     
- Misses         7431    14659     +7228     
+ Partials       1127      404      -723     
Flag Coverage Δ Complexity Δ
integrationtests ? ?
unittests 22.72% <5.28%> (-0.14%) 0.00 <5.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/main/kotlin/graphics/scenery/Node.kt 58.03% <0.00%> (-4.97%) 70.00 <0.00> (-11.00)
src/main/kotlin/graphics/scenery/Scene.kt 35.71% <0.00%> (-4.76%) 9.00 <0.00> (+1.00) :arrow_down:
...graphics/scenery/backends/vulkan/VulkanRenderer.kt 0.00% <0.00%> (-66.59%) 0.00 <0.00> (-84.00)
...hics/scenery/controls/behaviours/MouseDragPlane.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ics/scenery/controls/behaviours/MouseDragSphere.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...raphics/scenery/controls/behaviours/MouseRotate.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ry/controls/behaviours/RollingBallCameraControl.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...phics/scenery/controls/behaviours/SelectCommand.kt 0.00% <0.00%> (-46.67%) 0.00 <0.00> (-2.00)
...phics/scenery/effectors/LineRestrictionEffector.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../main/kotlin/graphics/scenery/volumes/OrthoView.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
... and 108 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 63eb65e...f544f71. Read the comment docs.

codecov[bot] avatar Apr 02 '21 15:04 codecov[bot]

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@8d22016). Click here to learn what that means. The diff coverage is n/a.

:exclamation: Current head 5e9c0d1 differs from pull request most recent head 22f18e1. Consider uploading reports for the commit 22f18e1 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #396   +/-   ##
=======================================
  Coverage        ?   22.72%           
  Complexity      ?      883           
=======================================
  Files           ?      175           
  Lines           ?    19492           
  Branches        ?     2994           
=======================================
  Hits            ?     4429           
  Misses          ?    14659           
  Partials        ?      404           
Flag Coverage Δ
unittests 22.72% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov-commenter avatar Apr 21 '21 16:04 codecov-commenter

Superseded by #622.

skalarproduktraum avatar Apr 02 '24 14:04 skalarproduktraum