Scenario-Unity icon indicating copy to clipboard operation
Scenario-Unity copied to clipboard

feat: 109 isometric building workflow

Open TheLLspectre opened this issue 1 year ago • 20 comments

Adding isometric workflow: Main features:

  • Select Base and also custom base

  • select model

  • define and select prompt to generate assets

  • Select generated asset to convert as sprite, as a tile to tile palette, customize in webapp

  • Regenerate an inference

  • Restart workflow

  • closes: #109

TheLLspectre avatar Mar 15 '24 11:03 TheLLspectre

Fixing conflicts after merging dev with 125

TheLLspectre avatar Mar 18 '24 08:03 TheLLspectre

Step1 window is not correctly sized when opening the first time on my mac: image

And is it possible to handle errors if models are not available rather than fetch error on console? Maybe we can have an outage or a model change, and we can just display an error message readable for the user, like "Model xxxx not available"?

qvaleroo avatar Mar 26 '24 12:03 qvaleroo

Select button display on Custom is broken: image

qvaleroo avatar Mar 26 '24 13:03 qvaleroo

Select buttons on Step 1 are broken after using the Select option on Custom https://github.com/scenario-labs/Scenario-Unity/assets/95273550/a7bd1bbc-a93e-40d7-ac69-f65598e58e35

qvaleroo avatar Mar 26 '24 13:03 qvaleroo

Isn't possible to go back to Previous Step? Display of Step2 is not really optimized either. Window cut the content

image

qvaleroo avatar Mar 26 '24 13:03 qvaleroo

lora1, lora2.... are final names? image

qvaleroo avatar Mar 26 '24 13:03 qvaleroo

Is it possible to click on the whole image rather than the little checkbox? image

qvaleroo avatar Mar 26 '24 13:03 qvaleroo

Issue with wording here no? No spaces and typo on Contemporary image

qvaleroo avatar Mar 26 '24 13:03 qvaleroo

Step1 window is not correctly sized when opening the first time on my mac: image

And is it possible to handle errors if models are not available rather than fetch error on console? Maybe we can have an outage or a model change, and we can just display an error message readable for the user, like "Model xxxx not available"?

You try to access it whitout the isometric workspace @qvaleroo ?

TheLLspectre avatar Mar 26 '24 13:03 TheLLspectre

Select button display on Custom is broken: image

Thanks @qvaleroo ! I didn't see that !

TheLLspectre avatar Mar 26 '24 13:03 TheLLspectre

Step 4 is really hard to understand, I didn't get I had to enter name of building in the field

https://github.com/scenario-labs/Scenario-Unity/assets/95273550/0470efdb-019f-4e97-b1c4-4fa1de9bbb07

qvaleroo avatar Mar 26 '24 13:03 qvaleroo

I didn't get why after step4 the prompt window automatically opened, or maybe just get in front row if it was open in background 🤔 image

qvaleroo avatar Mar 26 '24 13:03 qvaleroo

All titles change colour when I hover my mouse on it, we should avoid this as it is just a title (maybe it is only on Mac?) image

qvaleroo avatar Mar 26 '24 13:03 qvaleroo

Regarding step5:

  • You can click on buttons when they should be unclickable.
  • Restart 4 generations triggers an exception

https://github.com/scenario-labs/Scenario-Unity/assets/95273550/b6c3153f-146f-4791-b680-9c35270f9ede

qvaleroo avatar Mar 26 '24 13:03 qvaleroo

lora1, lora2.... are final names? image

Some models will be removed

TheLLspectre avatar Mar 26 '24 13:03 TheLLspectre

Select buttons on Step 1 are broken after using the Select option on Custom https://github.com/scenario-labs/Scenario-Unity/assets/95273550/a7bd1bbc-a93e-40d7-ac69-f65598e58e35

Not looking broken, if custom image are not filled you can't select it. The select button had a trouble. And same for square if you want to select it the selector goes back to null. May be it's not clear

TheLLspectre avatar Mar 26 '24 13:03 TheLLspectre

Select buttons on Step 1 are broken after using the Select option on Custom https://github.com/scenario-labs/Scenario-Unity/assets/95273550/a7bd1bbc-a93e-40d7-ac69-f65598e58e35

Not looking broken, if custom image are not filled you can't select it. The select button had a trouble. And same for square if you want to select it the selector goes back to null. May be it's not clear

In this case we should not be able to click on the Custom checkbox. Currently you can click and see an animation. Checkbox should just be disabled. Then if you click again on a selected checkbox, do not select another one. please leave everything unselect.

qvaleroo avatar Mar 26 '24 13:03 qvaleroo

Step 4 is really hard to understand, I didn't get I had to enter name of building in the field Screen.Recording.2024-03-26.at.14.07.40.mov

Yeap, I'm agree, I add a subtitle to add indication... but if you have any idea to improve it ????

TheLLspectre avatar Mar 26 '24 16:03 TheLLspectre

Step 4 is really hard to understand, I didn't get I had to enter name of building in the field Screen.Recording.2024-03-26.at.14.07.40.mov

Yeap, I'm agree, I add a subtitle to add indication... but if you have any idea to improve it ????

Maybe we can add buttons above like the prompt builder o nthe web to quickly add building types and understand what it is ? The Add Samples button is little bit mysterious and we don't know what will happen when clicking on it image

qvaleroo avatar Mar 26 '24 16:03 qvaleroo

@qvaleroo which models do we keep for the release in this window ? Could you make sure they will be available publicly before we merge into develop ? image

Morgan-6Freedom avatar Apr 03 '24 07:04 Morgan-6Freedom

We should not need the user to fill Workspace ID in settings. If you want the ID, you can have it with /teams endpoint image

qvaleroo avatar May 27 '24 14:05 qvaleroo

Is it possible to center the text and icon for custom isometric choice? image

qvaleroo avatar May 27 '24 14:05 qvaleroo

Some icons are empty image

qvaleroo avatar May 27 '24 14:05 qvaleroo

image Maybe replace "This consume Credits" by the actual cost value. You can obtain it sending the request with parameter dryRun = true (check with frontend team or backend team if help is needed)

qvaleroo avatar May 27 '24 14:05 qvaleroo

We should also handle Parallel inferences limit. Creator plan is limited to 5 inferences in // for example but I can send more than 5 ifnerences. You should queue the request when receiving a 429 error, and relaunch it once a request is finished for example. You have the max number of allowed parallel inferences using /team/{teamId}/limits endpoint

image

qvaleroo avatar May 27 '24 14:05 qvaleroo

Some icons are empty image

Some models are not available on download, when you're not on isometric workspace :/

TheLLspectre avatar May 31 '24 13:05 TheLLspectre