labstreaminglayer icon indicating copy to clipboard operation
labstreaminglayer copied to clipboard

Adding submodule for Trigno Wireless and Tobii Pro Nano

Open Zentetsu opened this issue 6 years ago • 3 comments

Hi,

I have worked during the last few months on two sublibraries for EMG and Eye-Tracker and I would like to share my work. I tested it on Windows, Linux and OSX.

Note: Currently, Eye-Tracker drivers are only provided for Windows and Mac.

Zentetsu avatar Sep 17 '19 09:09 Zentetsu

I haven't tested anything, but so far everything looks great.

Some thoughts:

  • I already wrote a TobiiPro connector that should handle the TobiiPro Nano. I don't have the device any more, so I'd gladly accept pull requests e.g. to add data (validity, 3D coordinates and so on to the stream) you need
  • Boost.Thread is a quite heavy dependency, especially since std::thread covers 99% of what it does and is supported by all recent compilers
  • the directory structure is a good idea, but for 8 source files it's somewhat easier to have everything in the root folder and avoids the #include "../include/..."
- if(WIN32)
	target_link_libraries(${PROJECT_NAME} PRIVATE
		libA
		libB
	)
endif()

can be shortened to

target_link_libraries(${PROJECT_NAME} PRIVATE
	libA
)
if(WIN32)
	target_link_libraries(${PROJECT_NAME} PRIVATE libForWindows)
endif()

Also, we'd need commit rights to the repositories so we can fix things. You could either transfer the repositories to the labstreaminglayer organization or add it to the repository. You'd keep the copyright and admin rights, of course.

tstenner avatar Sep 17 '19 10:09 tstenner

Also, see here for some conventions that make most boilerplate parts, e.g. config handling, easier

tstenner avatar Sep 17 '19 10:09 tstenner

Thank you for your answer. I will update the EMG sub-library to comply with your conventions.

Regarding the Eye-Tracker, I will not be able to test it because I'm leaving the lab where I used it.

Zentetsu avatar Sep 19 '19 07:09 Zentetsu