Change the compilation folder of X11RDP

[Elvinra]

For the moment, the binary created during the compilation is on the folder /opt/X11rdp but it's also the install folder for the deb package.

Change it for $WORKINGDIR/Build/X11RDP/opt/x11rdp and use $WORKINGDIR/Build/X11RDP for making the deb package.

[scarygliders]

o-matic uses the buildx.sh script supplied by the xorg source, and the way it's written at the moment, needs to be supplied with a destination directory, which traditionally is /opt/X11rdp.

To do what you suggest would probably need a re-write of that buildx.sh script, or a new script written specifically for o-matic, loosely based on buildx.sh.

That's a bit of work I don't currently have time to do at the moment.

[Elvinra]

No-need to rewrite buildx.sh.

Just change your script, "sh buildx.sh $WORKINGDIR/xrdp/xorg/debuild/x11rdp-files/opt/X11rdp"

/opt/X11rdp is traditionally for installation but the script just need a folder for building the package.

The best option :

• sh buildx.sh $WORKINGDIR/xrdp/xorg/debuild/x11rdp-files/opt/X11rdp and remove the line in your script cp -Rf $X11DIR $DESTDIR i don't have a linux in my hand but i think it's only 2 line to modifiy.

$WORKINGDIR/xrdp/xorg/debuild/x11rdp-files/opt/X11rdp is your new $X11DIR. It is not enter in conflict with other installation of X11DIR.

[metalefty]

Will it really work? Did you try? I don't think so.

[Elvinra]

I just finished to try and it's works. I only tried the compilation of X11rdp. i'm forking the project and create a pull request for this change but not today ^^

[metalefty]

Nice work! I'll try when you published the changes.

[scarygliders]

@Elvinra I'll give that a try today - thanks for your input by the way :+1:

[Elvinra]

In my fork : https://github.com/Elvinra/X11RDP-o-Matic/tree/devel It's not perfect, a little update is require.

[scarygliders]

@Elvinra Looking at your commit just now, but noticed you added the "-yes" flag to dh_make...

Unfortunately, that flag is not backwards-compatible with older debian-based Linux distro versions of dh_make, which stops dead when it sees a flag it doesn't recognise. I've already figured out a workaround for that though to make it backwards-compatible...

[Elvinra]

I remove -yes flag to dh_make now.

[scarygliders]

Hiya, I've incorporated your changes into the devel branch. I'll close this issue once I've completed tidying up the script, but it looks like your suggestion does indeed work :)

I've tested package generation using the xrdp master branch and it appears to have worked. Hoping others can test the devel version and provide further feedback.

[metalefty]

@scarygliders @Elvinra

It turned out tour changes are no good, not working now. I concerned that it may not work before. It actually doesn't work.

This is the same issue why I struggled and quit to build x11rdp in build directory in X11RDP-RH-Matic. X11rdp executable is looking for libraries in the directory where x11rdp had been built. This will never work. X11rdp executable should find libraries in install destination directory /opt/X11rdp, not the build directory.

Without rewriting buildx.sh, x11rdp must be built in /opt/X11rdp directory. We need to revert this changes at once.

Please see below log.

$ /opt/X11rdp/bin/X11rdp :10
InitOutput:

X11rdp, an X server for xrdp
Version 0.7.0
Copyright (C) 2005-2012 Jay Sorg
See http://xrdp.sf.net for information on xrdp.
Underlying X server release 10903000, The X.Org Foundation
Screen width 1024 height 768 depth 24 bpp 32
dpix 100 dpiy 100
buffer size 3145728
21/11/14 23:41:17 kill disconencted [0] timeout [60] sec
pRRScrPriv 0x1acbe80
rdpScreenInit: ret 1
InitOutput: out
(EE) AIGLX error: dlopen of /home/meta/X11RDP-o-Matic/xrdp/xorg/debuild/x11rdp-files//opt/X11rdp/lib/dri/swrast_dri.so failed (/home/meta/X11RDP-o-Matic/xrdp/xorg/debuild/x11rdp-files//opt/X11rdp/lib/dri/swrast_dri.so: cannot open shared object file: No such file or directory)
(EE) GLX: could not load software renderer
[dix] Could not init font path element /usr/share/fonts/X11/TTF/, removing from list!
[dix] Could not init font path element /usr/share/fonts/X11/OTF/, removing from list!
[dix] Could not init font path element /usr/share/fonts/X11/100dpi/, removing from list!
[dix] Could not init font path element /usr/share/fonts/X11/75dpi/, removing from list!
rdpSpriteDeviceCursorInitialize:
(EE) XKB: Couldn't open rules file /home/meta/X11RDP-o-Matic/xrdp/xorg/debuild/x11rdp-files//opt/X11rdp/share/X11/xkb/rules/base
XKB: Failed to compile keymap
Keyboard initialization failed. This could be a missing or incorrect setup of xkeyboard-config.

Fatal server error:
Failed to activate core devices.
DeleteInputDeviceRequest
DeleteInputDeviceRequest
ddxGiveUp:

[scarygliders]

@metalefty @Elvinra

Hmm. You're right. I can repeat the error. It seems I was correct when I said at first that buildx.sh would need to be re-written. I should have spotted this after the changes were made - I was blinded by the fact that X11rdp did seem to compile fine with the changes. It never occurred to me to manually run the resultant X11rdp binary after it was installed from the generated package.

I'll revert back to the old behaviour. Then we can try and figure out what to do about this later.

[scarygliders]

@metalefty @Elvinra

Reverted to the original behaviour. The changes simply won't work without using a different X11rdp build script. Needs a re-think.