scaramallion

Results 188 comments of scaramallion

SR is outside my area of expertise, I'm happy to defer to those with more experience

Thanks, I've been meaning to change the allowed types for `dcmwrite`

I think my reasoning was that the extra length may just be padding, but that is a little unrealistic... an exception probably makes more sense here

I'm not sure about how `DataElement.is_empty` should behave in this case, maybe return `False` if there are no items and update the docstring to explain the difference?

> I don't agree in this case Whoops, sorry. Wrote the opposite of what I meant

Any change to the transport service should support TLS v1.3 as well

I'm not against the idea, but I have no experience with them in practice so I've been reluctant to try and add something that may be wrong or just inconvenient...

@richard-moss if you could provide some suitable test datasets it'd help a lot

You can try [deid](https://github.com/pydicom/deid) for anonymisation. The more variations you can get for *Bits Allocated*, *Bits Stored*, *Pixel Representation* and *Samples per Pixel* the better.

> They're all 16 allocated, and the same representation etc sorry. No problem, I know how hard it can be to get a good variation in datasets. > Can I...