sweep-learning-examples icon indicating copy to clipboard operation
sweep-learning-examples copied to clipboard

BUG: in checkIfShouldMerge function

Open tyuownu opened this issue 8 years ago • 0 comments

Dear all, I found a bug in checkIfShouldMerge function. See below:

mergedSensorReadings = S1.sensorReadings.concat(S2.sensorReadings);
fit = _SENSOR_READING_UTILS.linearRegerssion(mergedSensorReadings);

in the first line, we shoud delete the duplicate point the S1 and S2, to construct a new pointcloud, beacuse the duplicate will affect the fit in the next line linearRegerssion function.

I do not know the language that this repo used, so I can not help to fix it, lol. Thanks

tyuownu avatar Jun 29 '17 12:06 tyuownu