Stéphane Campinas

Results 35 comments of Stéphane Campinas

@RalfJung I might be the oddball but I like the current formatting... It clearly separates the field of the struct from the method call, especially if you have many fields/calls.

`ExtendedIntervalsSource` explicitly returns -1, and this was done in https://github.com/apache/lucene/pull/803 (ticket [LUCENE-10229](https://issues.apache.org/jira/browse/LUCENE-10229)). https://github.com/apache/lucene/blob/6d987e1ce1c3f3215633a979ce048829fe1bb6ed/lucene/queries/src/java/org/apache/lucene/queries/intervals/ExtendedIntervalsSource.java#L89-L94 From the ticket: > The reason extend does not work for highlighting is that, quite reasonably, it...

In `OffsetsFromPositions` there is some logic to get offsets from positions. https://github.com/apache/lucene/blob/53d1c2bd2fb3e6b9da590bee360996dbbdc8ea34/lucene/highlighter/src/java/org/apache/lucene/search/matchhighlight/OffsetsFromPositions.java#L62 Would it make sense to apply a similar logic in `FieldHighlighter` in the case where offsets are missing...

@mwillsey you mean to reflect the enum's order on the match ? I don't think that is possible since we have only information coming from the AST

Jumping in as this interests me, sorry if I get some points wrong! It seems that `PointInSetIncludingScoreQuery` creates also a bitset from the scan of `PointValues` in `createWeight`. https://github.com/apache/lucene/blob/085a0ae054b1df9623afce47e28b65c52184ce48/lucene/join/src/java/org/apache/lucene/search/join/PointInSetIncludingScoreQuery.java#L203-L205 Several...