cbor icon indicating copy to clipboard operation
cbor copied to clipboard

Implementation of Ordered Insertion Maps for encoding/decoding

Open daidoji opened this issue 2 months ago • 2 comments

@tomciopp A long time ago I opened #5 when I was pretty new to Elixir and didn't know much or have much time to work on this. At the time you didn't want to implement ordered maps in the library but suggested I could send a PR. Just got around to implementing it here if you'd like to accept the contribution as something that some people might find useful. If not feel free to close.

daidoji avatar Oct 21 '25 16:10 daidoji

@daidoji Thanks for the PR. I don't think this is quite the correct direction that I want to take since there have been changes to the cbor spec. My instinct is to add an optional decoder map where keys correspond to known tags within the database of tags. This way people could write their own implementations and share them as extensions to the spec. Let me think about this some more before outright rejecting. I will likely have some time this weekend to gather my thoughts and work on a plan.

tomciopp avatar Oct 23 '25 22:10 tomciopp

@tomciopp thanks for the feedback and sure. Like I said just putting it out there. If I can help in any way please feel free to let me know.

daidoji avatar Oct 24 '25 00:10 daidoji