metalk8s icon indicating copy to clipboard operation
metalk8s copied to clipboard

salt: Fix shell-ui configuration upgrade

Open JBWatenbergScality opened this issue 4 years ago • 10 comments

Component:

salt, shell-ui

Context:

When upgrading from 2.9.x to 2.10.x we lost patches to OIDC and users groups mapping configuration.

Summary:

This solves it by copying the old configuration to the new CMs.

Acceptance criteria:

Tested an upgrade from 2.9 with patched configuration to 2.10.3-dev and the configuration was correctly kept.

Closes: #3496

JBWatenbergScality avatar Aug 16 '21 17:08 JBWatenbergScality

Hello jbwatenbergscality,

My role is to assist you with the merge of this pull request. Please type @bert-e help to get information on this process, or consult the user documentation.

Status report is not available.

bert-e avatar Aug 16 '21 17:08 bert-e

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

  • @nicolast

  • @teddyandrieux

  • @alexandre-allard-scality

  • @jbwatenbergscality

  • @lucieleonard

  • @chengyanjin

  • @gdemonet

  • @thomasdanan

bert-e avatar Aug 16 '21 17:08 bert-e

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

You can set option create_pull_requests if you need me to create integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

bert-e avatar Aug 17 '21 08:08 bert-e

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

  • @nicolast

  • @teddyandrieux

  • @alexandre-allard-scality

  • @jbwatenbergscality

  • @lucieleonard

  • @chengyanjin

  • @gdemonet

  • @thomasdanan

bert-e avatar Aug 17 '21 08:08 bert-e

History mismatch

Merge commit #86ee8886dfda1c337f3609220f901ec9e2f8fb40 on the integration branch w/2.11/bugfix/upgrade-shell-ui-version is merging a branch which is neither the current branch bugfix/upgrade-shell-ui-version nor the development branch development/2.11.

It is likely due to a rebase of the branch bugfix/upgrade-shell-ui-version and the merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

bert-e avatar Aug 17 '21 08:08 bert-e

/reset

JBWatenbergScality avatar Aug 17 '21 08:08 JBWatenbergScality

Reset complete

I have successfully deleted this pull request's integration branches.

bert-e avatar Aug 17 '21 08:08 bert-e

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

You can set option create_pull_requests if you need me to create integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

bert-e avatar Aug 17 '21 08:08 bert-e

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

  • @nicolast

  • @teddyandrieux

  • @alexandre-allard-scality

  • @jbwatenbergscality

  • @lucieleonard

  • @chengyanjin

  • @gdemonet

  • @thomasdanan

bert-e avatar Aug 17 '21 08:08 bert-e

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

  • @nicolast

  • @teddyandrieux

  • @alexandre-allard-scality

  • @jbwatenbergscality

  • @lucieleonard

  • @chengyanjin

  • @gdemonet

  • @thomasdanan

The following reviewers are expecting changes from the author, or must review again:

  • @gdemonet

bert-e avatar Aug 19 '21 07:08 bert-e