metalk8s
metalk8s copied to clipboard
Deleted iso solution should trigger comprehensive error message when using solutions.sh
Component:
solutions
What happened:
- load a solution
- remove the iso file (for some reason)
- load a new solution (different iso file content, path, name etc)
- solutions.sh failed as it could not find the previous iso (deleted) and run
isoinfo
on it.
What was expected:
- loading the second solution works
Steps to reproduce:
- same steps as What happened
Resolution proposal (optional):
- when checking all solutions iso file, if one does not exists, may be skip it depending on the expected result, if this iso file is not the one that we are looking for, or the one we want to load for example.
When an ISO is listed in the configuration, it must exist. If it does not exist, it should be reinstated, or the configuration must be fixed (though not simply as-is: removing a solution ISO requires a procedure to be executed, it's not sufficient to merely remove a line from the config: the config needs to be 'applied' as well).
We should not 'skip' missing solutions files listed in the config, essentially accepting a 'broken' configuration.
However, if such broken configuration is detected, we must make sure to properly handle this, i.e., with a useful error message. That may be lacking.
Renamed issue to match the exact problem.