cloudserver icon indicating copy to clipboard operation
cloudserver copied to clipboard

adding header handling in routeVeam + unit tests

Open benzekrimaha opened this issue 1 month ago • 6 comments

Issue: CLDSRV-806

benzekrimaha avatar Dec 08 '25 14:12 benzekrimaha

Hello benzekrimaha,

My role is to assist you with the merge of this pull request. Please type @bert-e help to get information on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval :star:
/bypass_build_status Bypass the build and test status :star:
/bypass_commit_size Bypass the check on the size of the changeset TBA :star:
/bypass_incompatible_branch Bypass the check on the source branch prefix :star:
/bypass_jira_check Bypass the Jira issue check :star:
/bypass_peer_approval Bypass the pull request peers' approval :star:
/bypass_leader_approval Bypass the pull request leaders' approval :star:
/approve Instruct Bert-E that the author has approved the pull request. :writing_hand:
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e avatar Dec 08 '25 14:12 bert-e

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 83.39%. Comparing base (60b7aa4) to head (55ea857). :warning: Report is 4 commits behind head on development/9.0. :white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/routes/routeVeeam.js 97.72% <100.00%> (+0.25%) :arrow_up:
@@                 Coverage Diff                 @@
##           development/9.0    #6022      +/-   ##
===================================================
+ Coverage            83.38%   83.39%   +0.01%     
===================================================
  Files                  189      189              
  Lines                12199    12208       +9     
===================================================
+ Hits                 10172    10181       +9     
  Misses                2027     2027              
Flag Coverage Δ
file-ft-tests 66.78% <18.18%> (-0.04%) :arrow_down:
kmip-ft-tests 26.98% <18.18%> (-0.01%) :arrow_down:
mongo-v0-ft-tests 68.11% <18.18%> (-0.04%) :arrow_down:
mongo-v1-ft-tests 68.12% <18.18%> (-0.01%) :arrow_down:
multiple-backend 35.67% <36.36%> (-0.01%) :arrow_down:
quota-tests 33.06% <18.18%> (-0.01%) :arrow_down:
quota-tests-inflights 34.17% <18.18%> (-0.01%) :arrow_down:
unit 67.61% <100.00%> (+0.02%) :arrow_up:
utapi-v2-tests 33.33% <18.18%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:rocket: New features to boost your workflow:
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 08 '25 14:12 codecov[bot]

branch is not up-to-date with upstream development/9.0 : needs to be rebase and resolve conflicts...

francoisferrand avatar Dec 09 '25 16:12 francoisferrand

Incorrect fix version

The Fix Version/s in issue CLDSRV-806 contains:

  • 9.1.6

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.0.34

  • 9.1.7

  • 9.2.9

Please check the Fix Version/s of CLDSRV-806, or the target branch of this pull request.

bert-e avatar Dec 10 '25 13:12 bert-e

Incorrect fix version

The Fix Version/s in issue CLDSRV-806 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.0.34

  • 9.1.7

  • 9.2.9

Please check the Fix Version/s of CLDSRV-806, or the target branch of this pull request.

bert-e avatar Dec 10 '25 13:12 bert-e

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically create the integration branches.

bert-e avatar Dec 10 '25 15:12 bert-e

Incorrect fix version

The Fix Version/s in issue CLDSRV-806 contains:

  • 9.0.34

  • 9.1.7

  • 9.2.9

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.0.34

  • 9.1.7

  • 9.2.10

Please check the Fix Version/s of CLDSRV-806, or the target branch of this pull request.

bert-e avatar Dec 12 '25 09:12 bert-e

/create_integration_branches

benzekrimaha avatar Dec 12 '25 11:12 benzekrimaha

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

bert-e avatar Dec 12 '25 11:12 bert-e

/create_pull_requests

benzekrimaha avatar Dec 12 '25 11:12 benzekrimaha

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8

Follow integration pull requests if you would like to be notified of build statuses by email.

The following options are set: create_pull_requests, create_integration_branches

bert-e avatar Dec 12 '25 11:12 bert-e

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_pull_requests, create_integration_branches

bert-e avatar Dec 12 '25 11:12 bert-e

/approve

benzekrimaha avatar Dec 12 '25 11:12 benzekrimaha

I have successfully merged the changeset of this pull request into targetted development branches:

  • :heavy_check_mark: development/9.0

  • :heavy_check_mark: development/9.1

  • :heavy_check_mark: development/9.2

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8

Please check the status of the associated issue CLDSRV-806.

Goodbye benzekrimaha.

The following options are set: approve, create_pull_requests, create_integration_branches

bert-e avatar Dec 12 '25 11:12 bert-e