cloudserver
cloudserver copied to clipboard
build(deps): bump node-forge from 0.7.6 to 1.3.0
Bumps node-forge from 0.7.6 to 1.3.0.
Changelog
Sourced from node-forge's changelog.
1.3.0 - 2022-03-17
Security
- Three RSA PKCS#1 v1.5 signature verification issues were reported by Moosa Yahyazadeh ([email protected]).
- HIGH: Leniency in checking
digestAlgorithm
structure can lead to signature forgery.
- The code is lenient in checking the digest algorithm structure. This can allow a crafted structure that steals padding bytes and uses unchecked portion of the PKCS#1 encoded message to forge a signature when a low public exponent is being used. For more information, please see "Bleichenbacher's RSA signature forgery based on implementation error" by Hal Finney.
- CVE ID: CVE-2022-24771
- GHSA ID: GHSA-cfm4-qjh2-4765
- HIGH: Failing to check tailing garbage bytes can lead to signature forgery.
- The code does not check for tailing garbage bytes after decoding a
DigestInfo
ASN.1 structure. This can allow padding bytes to be removed and garbage data added to forge a signature when a low public exponent is being used. For more information, please see "Bleichenbacher's RSA signature forgery based on implementation error" by Hal Finney.- CVE ID: CVE-2022-24772
- GHSA ID: GHSA-x4jg-mjrx-434g
- MEDIUM: Leniency in checking type octet.
DigestInfo
is not properly checked for proper ASN.1 structure. This can lead to successful verification with signatures that contain invalid structures but a valid digest.- CVE ID: CVE-2022-24773
- GHSA ID: GHSA-2r2c-g63r-vccr
Fixed
- [asn1] Add fallback to pretty print invalid UTF8 data.
- [asn1]
fromDer
is now more strict and will default to ensuring all input bytes are parsed or throw an error. A new optionparseAllBytes
can disable this behavior.
- NOTE: The previous behavior is being changed since it can lead to security issues with crafted inputs. It is possible that code doing custom DER parsing may need to adapt to this new behavior and optional flag.
- [rsa] Add and use a validator to check for proper structure of parsed ASN.1
RSASSA-PKCS-v1_5
DigestInfo
data. Additionally check that the hash algorithm identifier is a known value from RFC 8017PKCS1-v1-5DigestAlgorithms
. An invalidDigestInfo
or algorithm identifier will now throw an error.
- NOTE: The previous lenient behavior is being changed to be more strict since it could lead to security issues with crafted inputs. It is possible that code may have to handle the errors from these stricter checks.
... (truncated)
Commits
6c5b901
Release 1.3.0.0f3972a
Update changelog.dc77b39
Fix error checking.bb822c0
Add advisory links.d4395fe
Update changelog.a4405bb
Improve signature verification tests.aa9372d
Add missing RFC 8017 algorithm identifiers.3f0b49a
Fix signature verification issues.c20f309
Adjust remaining length.e27f612
Remove unused option.- Additional commits viewable in compare view
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase
.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
-
@dependabot rebase
will rebase this PR -
@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it -
@dependabot merge
will merge this PR after your CI passes on it -
@dependabot squash and merge
will squash and merge this PR after your CI passes on it -
@dependabot cancel merge
will cancel a previously requested merge and block automerging -
@dependabot reopen
will reopen this PR if it is closed -
@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually -
@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) -
@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) -
@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the Security Alerts page.
Hello dependabot[bot],
My role is to assist you with the merge of this
pull request. Please type @bert-e help
to get information
on this process, or consult the user documentation.
Status report is not available.
The following options are set: bypass_author_approval, bypass_jira_check
Waiting for approval
The following approvals are needed before I can proceed with the merge:
-
the author
-
2 peers
The following options are set: bypass_author_approval, bypass_jira_check
Conflict
There is a conflict between your branch dependabot/npm_and_yarn/node-forge-1.3.0
and the
destination branch development/8.4
.
Please resolve the conflict on the feature branch (dependabot/npm_and_yarn/node-forge-1.3.0
).
git fetch && \
git checkout origin/dependabot/npm_and_yarn/node-forge-1.3.0 && \
git merge origin/development/8.4
Resolve merge conflicts and commit
git push origin HEAD:dependabot/npm_and_yarn/node-forge-1.3.0
The following options are set: bypass_author_approval, bypass_jira_check
Waiting for approval
The following approvals are needed before I can proceed with the merge:
-
the author
-
2 peers
The following options are set: bypass_author_approval, bypass_jira_check
Branches have diverged
This pull request's source branch dependabot/npm_and_yarn/node-forge-1.3.0
has diverged from
development/8.5
by more than 50 commits.
To avoid any integration risks, please re-synchronize them using one of the following solutions:
- Merge
origin/development/8.5
intodependabot/npm_and_yarn/node-forge-1.3.0
- Rebase
dependabot/npm_and_yarn/node-forge-1.3.0
ontoorigin/development/8.5
Note: If you choose to rebase, you may have to ask me to rebuild
integration branches using the reset
command.
The following options are set: bypass_author_approval, bypass_jira_check
Integration data created
I have created the integration data for the additional destination branches.
- this pull request will merge
dependabot/npm_and_yarn/node-forge-1.3.0
intodevelopment/8.5
-
w/8.6/dependabot/npm_and_yarn/node-forge-1.3.0 will be merged into
development/8.6
-
w/8.7/dependabot/npm_and_yarn/node-forge-1.3.0 will be merged into
development/8.7
The following branches will NOT be impacted:
-
development/7.10
-
development/7.4
-
development/7.70
-
development/8.4
You can set option create_pull_requests
if you need me to create
integration pull requests in addition to integration branches, with:
@bert-e create_pull_requests
The following options are set: bypass_author_approval, bypass_jira_check
Waiting for approval
The following approvals are needed before I can proceed with the merge:
-
the author
-
2 peers
The following options are set: bypass_author_approval, bypass_jira_check
History mismatch
Merge commit #11b1d959983595f1f71b59e7e24baab00172b68e on the integration branch
w/8.7/dependabot/npm_and_yarn/node-forge-1.3.0
is merging a branch which is neither the current
branch dependabot/npm_and_yarn/node-forge-1.3.0
nor the development branch
development/8.7
.
It is likely due to a rebase of the branch dependabot/npm_and_yarn/node-forge-1.3.0
and the
merge is not possible until all related w/*
branches are deleted or updated.
Please use the reset
command to have me reinitialize these branches.
The following options are set: bypass_author_approval, bypass_jira_check
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version
or @dependabot ignore this minor version
. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore
condition with the desired update_types
to your config file.
If you change your mind, just re-open this PR and I'll resolve any conflicts on it.