Replace backbeat client with cloudserver client

[SylvainSenechal]

WIP Issue: BB-706

[bert-e]

Hello sylvainsenechal,

My role is to assist you with the merge of this pull request. Please type @bert-e help to get information on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	:star:
/bypass_build_status	Bypass the build and test status	:star:
/bypass_commit_size	Bypass the check on the size of the changeset TBA	:star:
/bypass_incompatible_branch	Bypass the check on the source branch prefix	:star:
/bypass_jira_check	Bypass the Jira issue check	:star:
/bypass_peer_approval	Bypass the pull request peers' approval	:star:
/bypass_leader_approval	Bypass the pull request leaders' approval	:star:
/approve	Instruct Bert-E that the author has approved the pull request.		:writing_hand:
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request TBA
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[codecov[bot]]

Codecov Report

:x: Patch coverage is 62.58597% with 272 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 74.24%. Comparing base (66c19b0) to head (19e0184). :warning: Report is 38 commits behind head on development/9.1.

Files with missing lines	Patch %	Lines
...xtensions/replication/tasks/MultipleBackendTask.js	59.18%	60 Missing :warning:
extensions/replication/utils/SetupReplication.js	4.76%	60 Missing :warning:
lib/BackbeatMetadataProxy.js	30.23%	30 Missing :warning:
extensions/replication/tasks/CopyLocationTask.js	72.16%	27 Missing :warning:
extensions/replication/management.js	4.16%	23 Missing :warning:
lib/queuePopulator/IngestionProducer.js	69.86%	22 Missing :warning:
extensions/lifecycle/management.js	5.88%	16 Missing :warning:
lib/clients/utils.js	65.38%	9 Missing :warning:
lib/credentials/CredentialsManager.js	75.75%	8 Missing :warning:
extensions/utils/VaultClientWrapper.js	16.66%	5 Missing :warning:
... and 5 more

Additional details and impacted files

Files with missing lines	Coverage Δ
extensions/gc/tasks/GarbageCollectorTask.js	87.28% <100.00%> (+0.10%)	:arrow_up:
...ecycle/bucketProcessor/LifecycleBucketProcessor.js	79.87% <100.00%> (+0.38%)	:arrow_up:
.../lifecycle/tasks/LifecycleColdStatusArchiveTask.js	89.79% <100.00%> (ø)
extensions/lifecycle/tasks/LifecycleTaskV2.js	88.88% <ø> (ø)
lib/clients/ClientManager.js	66.66% <100.00%> (+1.96%)	:arrow_up:
lib/credentials/AccountCredentials.js	64.10% <100.00%> (+0.94%)	:arrow_up:
lib/credentials/RoleCredentials.js	98.00% <100.00%> (+0.32%)	:arrow_up:
lib/tasks/BackbeatTask.js	97.36% <ø> (ø)
...sions/lifecycle/tasks/LifecycleDeleteObjectTask.js	92.85% <93.33%> (+0.34%)	:arrow_up:
extensions/lifecycle/tasks/LifecycleTask.js	91.54% <95.65%> (+0.02%)	:arrow_up:
... and 13 more

... and 10 files with indirect coverage changes

Components	Coverage Δ
Bucket Notification	80.36% <ø> (ø)
Core Library	80.33% <62.00%> (-0.70%)	:arrow_down:
Ingestion	70.61% <69.86%> (+0.30%)	:arrow_up:
Lifecycle	78.28% <81.81%> (-0.07%)	:arrow_down:
Oplog Populator	85.06% <ø> (ø)
Replication	59.94% <58.21%> (-1.25%)	:arrow_down:
Bucket Scanner	85.76% <ø> (+0.15%)	:arrow_up:

@@                 Coverage Diff                 @@
##           development/9.1    #2679      +/-   ##
===================================================
- Coverage            74.81%   74.24%   -0.58%     
===================================================
  Files                  201      200       -1     
  Lines                13579    13564      -15     
===================================================
- Hits                 10159    10070      -89     
- Misses                3410     3484      +74     
  Partials                10       10              

Flag	Coverage Δ
api:retry	9.36% <2.75%> (-0.14%)	:arrow_down:
api:routes	9.18% <0.96%> (-0.13%)	:arrow_down:
bucket-scanner	85.76% <ø> (+0.15%)	:arrow_up:
ft_test:queuepopulator	9.00% <0.27%> (-1.33%)	:arrow_down:
ingestion	12.50% <8.52%> (-0.06%)	:arrow_down:
lib	7.55% <0.41%> (-0.24%)	:arrow_down:
lifecycle	18.86% <10.59%> (-0.08%)	:arrow_down:
notification	1.03% <0.00%> (-0.01%)	:arrow_down:
replication	18.46% <38.23%> (-0.31%)	:arrow_down:
unit	50.76% <19.11%> (+0.03%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• 2 peers

[bert-e]

Incorrect fix version

The Fix Version/s in issue BB-706 contains:

• 9.2.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 9.1.1

Please check the Fix Version/s of BB-706, or the target branch of this pull request.

[bert-e]

Incorrect fix version

The Fix Version/s in issue BB-706 contains:

• 9.2.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 9.1.2

Please check the Fix Version/s of BB-706, or the target branch of this pull request.

[bert-e]

Incorrect fix version

The Fix Version/s in issue BB-706 contains:

• 9.2.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 9.1.3

Please check the Fix Version/s of BB-706, or the target branch of this pull request.

[SylvainSenechal]

Should probably create a follow up ticket (edit : created : https://scality.atlassian.net/jira/software/c/projects/OS/boards/268?selectedIssue=BB-730)

• [ ] cleanup err.name / err.code
• [ ] bin/ensureServiceUser line 167 https://scality.atlassian.net/browse/VAULT-238
• [ ] smithy proper errors (to be used with instanceof)
• [ ] Request ID for s3 sdk calls, and maybe for cloudserver client calls too ?
• [ ] Have centralized function to create s3/cloudserver clients
• [ ] Refactor s3/cloudserver client mocks ?

Other things to check now for this ticket :

• [x] tests/functional/queuePopulator/queuePopulator.spec.js recheck tests with Maha
• [ ] Put back the old test.yml sequential test instead of matrix

[bert-e]

Incorrect fix version

The Fix Version/s in issue BB-706 contains:

• 9.2.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 9.1.4

Please check the Fix Version/s of BB-706, or the target branch of this pull request.