Zenko icon indicating copy to clipboard operation
Zenko copied to clipboard

Improvement/zenko 4617 integrate kfkacleaner

Open KillianG opened this issue 1 year ago • 6 comments

This pull request primarily introduces changes to integrate a Kafka cleaner and to enhance the testing of Kafka's consumed messages. The Kafka cleaner is a new component added to the Zenko solution, which is reflected in the configuration files. The testing enhancements include a new test case and additional testing libraries.

Integration of Kafka Cleaner:

  • .github/scripts/end2end/configs/zenko.yaml: Added a Kafka cleaner with a specified interval.
  • .github/scripts/end2end/configs/zenkoversion.yaml: Added image and tag details for the Kafka cleaner.
  • solution/deps.yaml: Added the Kafka cleaner with sourceRegistry, image, tag, and envsubst details.
  • solution/zenkoversion.yaml: Added the Kafka cleaner to the Zenko version configuration with image and tag details. [1] [2]

Enhancements to Kafka Testing:

  • .github/scripts/end2end/run-e2e-ctst.sh: Added an INSTANCE_ID to the world parameters.
  • tests/ctst/common/common.ts: Imported additional libraries and added a new function to get topic offsets, and a new test case to verify that consumed Kafka messages do not take up too much disk space. [1] [2]
  • tests/ctst/features/zzz.kafkaCleaner.feature: Added a new feature file to test the Kafka cleaner.
  • tests/ctst/package.json: Added the KafkaJS library to the package dependencies.
  • tests/ctst/world/Zenko.ts: Added an InstanceID to the ZenkoWorldParameters interface.

KillianG avatar Feb 15 '24 10:02 KillianG

Hello killiang,

My role is to assist you with the merge of this pull request. Please type @bert-e help to get information on this process, or consult the user documentation.

Status report is not available.

bert-e avatar Feb 15 '24 10:02 bert-e

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically create the integration branches.

bert-e avatar Feb 15 '24 10:02 bert-e

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically create the integration branches.

bert-e avatar Feb 15 '24 10:02 bert-e

/create_integration_branches

KillianG avatar Feb 15 '24 10:02 KillianG

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/2.5

You can set option create_pull_requests if you need me to create integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

bert-e avatar Feb 15 '24 16:02 bert-e

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

bert-e avatar Mar 13 '24 13:03 bert-e

/approve

KillianG avatar Mar 14 '24 09:03 KillianG

In the queue

The changeset has received all authorizations and has been added to the relevant queue(s). The queue(s) will be merged in the target development branch(es) as soon as builds have passed.

The changeset will be merged in:

  • :heavy_check_mark: development/2.6

  • :heavy_check_mark: development/2.7

  • :heavy_check_mark: development/2.8

  • :heavy_check_mark: development/2.9

The following branches will NOT be impacted:

  • development/2.5

There is no action required on your side. You will be notified here once the changeset has been merged. In the unlikely event that the changeset fails permanently on the queue, a member of the admin team will contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a member of the admin team now.

The following options are set: approve, create_integration_branches

bert-e avatar Mar 14 '24 12:03 bert-e

I have successfully merged the changeset of this pull request into targetted development branches:

  • :heavy_check_mark: development/2.6

  • :heavy_check_mark: development/2.7

  • :heavy_check_mark: development/2.8

  • :heavy_check_mark: development/2.9

The following branches have NOT changed:

  • development/2.5

Please check the status of the associated issue ZENKO-4617.

Goodbye killiang.

bert-e avatar Mar 15 '24 00:03 bert-e