ultraviolet icon indicating copy to clipboard operation
ultraviolet copied to clipboard

feat(SelectInputV2): various improvements

Open lisalupi opened this issue 1 year ago • 2 comments

Summary

Type

  • Enhancement

Summarise concisely:

What is expected?

<SelectInputV2 />:

  • Hide search when less than 6 items (even when searchable = true)
  • Clickable footer to close the dropdown
  • clearable = false by default now
  • Dropdown will close when clicking outside when it is inside a modal

The following changes were made:

  1. Changed default value of prop clearable
  2. Changed type of prop footer
  3. Manage case selectInput in a modal
  4. Updated stories
  5. Added test for footer

lisalupi avatar Oct 10 '24 15:10 lisalupi

🦋 Changeset detected

Latest commit: 2cad86b8994a660c2a24bbef1bddb68bbe0bb92f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 10 '24 15:10 changeset-bot[bot]

Codecov Report

Attention: Patch coverage is 20.68966% with 23 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@6fc92ce). Learn more about missing BASE report. Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../components/SelectInputV2/__tests__/index.test.tsx 5.88% 16 Missing :warning:
...kages/ui/src/components/SelectInputV2/Dropdown.tsx 45.45% 6 Missing :warning:
packages/ui/src/components/SelectInputV2/index.tsx 0.00% 1 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4339   +/-   ##
=======================================
  Coverage        ?   86.75%           
=======================================
  Files           ?      322           
  Lines           ?    11789           
  Branches        ?     3273           
=======================================
  Hits            ?    10228           
  Misses          ?     1561           
  Partials        ?        0           
Files with missing lines Coverage Δ
packages/ui/src/components/SelectInputV2/index.tsx 57.50% <0.00%> (ø)
...kages/ui/src/components/SelectInputV2/Dropdown.tsx 43.75% <45.45%> (ø)
.../components/SelectInputV2/__tests__/index.test.tsx 10.76% <5.88%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6fc92ce...2cad86b. Read the comment docs.

codecov[bot] avatar Oct 10 '24 15:10 codecov[bot]