ultraviolet icon indicating copy to clipboard operation
ultraviolet copied to clipboard

fix(Navigation): add a prop to disable animation if needed

Open matthprost opened this issue 1 year ago • 2 comments

Summary

Type

  • Enhancement

Summarise concisely:

What is expected?

  • On <Expandable /> component, when prop animationDuration is set to 0 it will remove the animation of the component
  • Add animation prop on <NavigationProvider /> to disable all animations on Navigation

matthprost avatar Jul 08 '24 14:07 matthprost

🦋 Changeset detected

Latest commit: 9fa564022211eeec37e06ffa5c0d805e2a7f75d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Minor
@ultraviolet/plus Minor
@ultraviolet/form Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jul 08 '24 14:07 changeset-bot[bot]

Codecov Report

Attention: Patch coverage is 11.53846% with 23 lines in your changes missing coverage. Please review.

Project coverage is 94.23%. Comparing base (dcd7e34) to head (9fa5640). Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3983      +/-   ##
==========================================
- Coverage   94.41%   94.23%   -0.19%     
==========================================
  Files         191      192       +1     
  Lines        6335     6378      +43     
  Branches     2902     2917      +15     
==========================================
+ Hits         5981     6010      +29     
- Misses        354      368      +14     
Files Coverage Δ
packages/ui/src/components/Expandable/index.tsx 48.00% <11.53%> (-12.53%) :arrow_down:

... and 15 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dcd7e34...9fa5640. Read the comment docs.

codecov[bot] avatar Jul 08 '24 14:07 codecov[bot]