ultraviolet icon indicating copy to clipboard operation
ultraviolet copied to clipboard

fix: text input and date input to be fixed

Open matthprost opened this issue 1 year ago • 2 comments

Summary

Type

  • Bug

Summarise concisely:

What is expected?

Fix <TextInputV2 /> prop onChange will now take function with event.

// Before
onChange={(value) => value}

// After
onChange={(event) => event.target.value}

This will also fix <DateInput /> issues such as editing the input value.

matthprost avatar Jul 02 '24 16:07 matthprost

🦋 Changeset detected

Latest commit: 4f947627e638f453c7c3c04327f5578c3d36e86d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/form Patch
@ultraviolet/ui Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jul 02 '24 16:07 changeset-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.22%. Comparing base (1d813c7) to head (4f94762).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3944   +/-   ##
=======================================
  Coverage   94.21%   94.22%           
=======================================
  Files         192      192           
  Lines        6380     6386    +6     
  Branches     2918     2918           
=======================================
+ Hits         6011     6017    +6     
  Misses        369      369           
Files Coverage Δ
...ges/form/src/components/TextInputFieldV2/index.tsx 91.66% <100.00%> (+0.36%) :arrow_up:
packages/ui/src/components/DateInput/index.tsx 100.00% <ø> (ø)
packages/ui/src/components/SearchInput/index.tsx 95.41% <100.00%> (+0.04%) :arrow_up:
...src/components/SelectInputV2/SearchBarDropdown.tsx 98.64% <100.00%> (ø)
packages/ui/src/components/TextInputV2/index.tsx 89.25% <100.00%> (+0.46%) :arrow_up:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1d813c7...4f94762. Read the comment docs.

codecov[bot] avatar Jul 02 '24 16:07 codecov[bot]