Conditional deprecation Server.IPV6 ?

[krajorama]

I was going to update the use of this SDK in Prometheus, but saw deprecation warnings and got confused. I've never seen a conditional deprecation:

// Deprecated: IPv6: instance IPv6 address (deprecated when `routed_ip_enabled` is `True`).
	IPv6 *ServerIPv6 `json:"ipv6"`

I would argue that if the field is not removed eventually (i.e. kept for the case when router_ip_enabled is False) then this is no deprecation at all and the comment should just say , "always nil when routed_ip_enabled is True".

WDYT?

[Codelax]

routed_ip_enabled is being pushed as the new default. I find valid to consider this field as deprecated. The documentation line and the deprecation notice is an input of the team developing this API. I you have not already I would recommend switching and using routed_ip_enabled. There is a news report about the change and a blog post.