scaleway-cli icon indicating copy to clipboard operation
scaleway-cli copied to clipboard

Add custom rule edition for security groups using an $EDITOR

Open remyleone opened this issue 5 years ago • 3 comments

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Security groups can have many custom rules that can be cumbersome to edit and write one by one. Do so in the CLI could potentially take a long time to develop. It would be more effective to have an interactive way to edit them based on an editor such as git rebase -i. By doing so, we can leverage the knowledge of our users with their favorite text editor.

The text would look like this:

enable_smtp: true
# Inbound rules are applied to the network flux coming IN of your instance
inbound_rules:
  - {rule: deny,   protocol: tcp, port: 42, ip_range: 0.0.0.0/0}
# Outbound rules are applied to the network flux coming OUT of your instance
outbound_rules:
  - {rule: accept, protocol: tcp, port: 42, ip_range: 0.0.0.0/0}

How I imagine scw could expose this functionality

scw instance security-group edit

References

  • git rebase -i
  • https://github.com/AlecAivazis/survey
  • kubectl edit

remyleone avatar May 07 '20 17:05 remyleone

Requires #1171

jerome-quere avatar Jul 10 '20 14:07 jerome-quere

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 08 '20 15:10 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 06 '21 17:01 stale[bot]