CSLinearLayoutView
CSLinearLayoutView copied to clipboard
Various improvements + Adding shortcuts for labels & images
Hey Charles,
thanks for your Linear Layout View! I built something similar some time ago. But your approach (with wrapped LayoutItems) is better than mine. Still I had some Ideas, that would also improve your layout class. I would love, if you would merge them.
There are 6 commits, the commit message explains most of them. But here are some more comments:
e39bf56 fixed missing scroll indicators: The ScrollIndicators are actual subviews of a UIScrollView, so you remove them in removeAllItems currently.
ee2482a respect scrollView content insets: The sizes are currently wrong, if so. uses insets on the scrollView
cda57ed performance increase | only relayout, if needed: All of your layout code gets calles on every scrolling movement (change in contentOffset). This results in a quite bad scrolling performance (depending on device and count of layoutItems)
98ac5a2 added adding shortcuts for text & images: I like to have a fast way to display some images and texts in a UIScrollView - if you don't think this should be part of your class, leave this commit out. But I like it very much.
Cheers Markus (@jaydee3 on twitter)
Also I would suggest to rename your class to CSLinearLayoutScrollView or CSFlowLayoutScrollView (Mine was JDFlowLayoutScrollView ,) ). What do you think? :+1:
Hey Markus, thanks for this. I haven't had a free moment to look through in detail, but I do plan on merging some of your work.. probably this weekend. Cheers.
Yes great. If you have any questions or other opinions on the code, talk to me :v:
Well both you guys are smarter than I am. I'm trying to get items added to autoresize on rotation but am not having any success.
Any pointers would be greatly appreciated and thanx in advance.
Anything new here? :)