scalastyle-maven-plugin icon indicating copy to clipboard operation
scalastyle-maven-plugin copied to clipboard

Published 20 hours ago • verified publisher icon scalastyle

scala style threadsafe

Open smanikim opened this issue 7 years ago • 11 comments

  • Upgraded libs to remove non-threadSafe dependency
  • Marked as thread safe

smanikim avatar Jan 05 '18 11:01 smanikim

@matthewfarwell Regarding communication on https://github.com/scalastyle/scalastyle/issues/291#issuecomment-349566107, I am trying to start it now. Test failing for JAVA_HOME

smanikim avatar Jan 05 '18 11:01 smanikim

I'm happy to do this. Was there a reason why you changed the dependencies?

matthewfarwell avatar Jan 25 '18 08:01 matthewfarwell

@matthewfarwell those dependencies were not thread-safe, so had to upgrade them. By the way, it has one commit left which is yet to be published.

smanikim avatar Jan 25 '18 09:01 smanikim

@smanikim Hi, could you tell me what the status of this is please? I want to do a release soon, and it would be nice if this were included.

matthewfarwell avatar Mar 18 '18 08:03 matthewfarwell

@matthewfarwell could you check into build failure Once that is fixed, there was some other local changes which I can push

smanikim avatar Mar 27 '18 03:03 smanikim

@matthewfarwell reminder

smanikim avatar Apr 09 '18 09:04 smanikim

@matthewfarwell another reminder :)

smanikim avatar May 09 '18 06:05 smanikim

@dasbh as well

smanikim avatar May 09 '18 09:05 smanikim

Can you explain, the dependencies change? Is the change still valid? Is this PR ready to go from your side?

ScrapCodes avatar Dec 10 '19 06:12 ScrapCodes

I don't remember it by heart. But looking at changes, it should be good

smanikim avatar Dec 10 '19 06:12 smanikim

Hi! Will this PR be merged in the near future?

Jenya95 avatar Dec 26 '22 11:12 Jenya95