scalapb-json4s icon indicating copy to clipboard operation
scalapb-json4s copied to clipboard

Update protobuf-java, protobuf-java-util to 3.24.4

Open scala-steward opened this issue 2 years ago • 1 comments

About this PR

📦 Updates

from 3.21.12 to 3.24.4

📜 GitHub Release Notes - Version Diff

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.google.protobuf" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.google.protobuf" }
}]
labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

scala-steward avatar Oct 04 '23 19:10 scala-steward

  • https://github.com/scalapb/scalapb-json4s/pull/423
  • https://github.com/scalapb/scalapb-json4s/actions/runs/6410479692/job/17403865273?pr=418#step:5:99
[info] Value
[info] - should be serialized the same as in Java (and parsed back to original) *** FAILED ***
[info]   java.lang.IllegalArgumentException: google.protobuf.Value cannot encode double values for infinity or nan, because they would be parsed as a string.
[info]   at com.google.protobuf.util.JsonFormat$PrinterImpl.printValue(JsonFormat.java:972)
[info]   at com.google.protobuf.util.JsonFormat$PrinterImpl.access$1600(JsonFormat.java:708)
[info]   at com.google.protobuf.util.JsonFormat$PrinterImpl$7.print(JsonFormat.java:843)
[info]   at com.google.protobuf.util.JsonFormat$PrinterImpl.print(JsonFormat.java:760)
[info]   at com.google.protobuf.util.JsonFormat$Printer.appendTo(JsonFormat.java:367)
[info]   at com.google.protobuf.util.JsonFormat$Printer.print(JsonFormat.java:377)
[info]   at scalapb.json4s.JavaAssertions.assertJsonIsSameAsJava(JavaAssertions.scala:65)

xuwei-k avatar Oct 19 '23 11:10 xuwei-k