scalapb-grpcweb icon indicating copy to clipboard operation
scalapb-grpcweb copied to clipboard

Question about server-side grpc-web support

Open visortelle opened this issue 3 years ago • 5 comments

Hello.

What about built-in server-side grpc-web support to eliminate additional proxies like Envoy?

Like it's done here: https://docs.rs/tonic-web/latest/tonic_web/

Is there any chance that it may be done in the scope of the ScalaPB project or its better to wait for news on this topic from https://github.com/grpc/grpc-java ?

Thank you.

visortelle avatar Sep 06 '22 07:09 visortelle

One reason I want this is to greatly simplify my e2e tests. It would be nice to have a single test that could run on both platforms.

steinybot avatar Jul 15 '24 18:07 steinybot

It would be nice if there was a Java implementation we could use. I'm not sure what it takes to write and maintain an implementation of a simple grpc-web server that is relatively simple (for tests only) though I am happy to accept a PR for that.

thesamet avatar Jul 16 '24 02:07 thesamet

Where do the shaded versions of io.grpc come from? I see them being added to grpcweb/target/scala-2.12/classes/io/grpc but how do they get there?

steinybot avatar Jul 16 '24 09:07 steinybot

I don't believe there is any shading. But maybe you mean the fake ones created in this project? The sources are under grpcweb/src/main/scala/io/grpc/

thesamet avatar Jul 16 '24 15:07 thesamet

Thanks. For some reason I thought there was more to it than that.

steinybot avatar Jul 16 '24 18:07 steinybot