Stale "compiling" loading progress bars never go away

[harpocrates]

Describe the bug

I've unfortunately not yet managed to distill out a clear repro for this, but it seems related to reconnecting to the build server just as a compile had started.

Some facts I think are relevant:

• This uses SBT as the BSP
• Project has a number of targets

I see:

• the "Compiling" progress bars appear, but percent progress doesn't update
• the time spent compiling in the progress bar does continue counting up
• the BSP logs (and in the IDE experience) seems to indicate that the compilation is up to date

Expected behavior

The "compiling" progress notifications should be dismissed once they finish or when reconnecting.

I see in the ForwardingMetalsBuildClient.scala that there is some logic meant to clear out the pending workDoneProgress's when reconnecting but I wonder if there's some race condition there.

Operating system

Windows

Editor/Extension

VS Code

Version of Metals

1.5.2

Extra context or search terms

No response

[tgodzik]

It's possible this will be fixed by https://github.com/scalameta/metals/pull/6691

[harpocrates]

Oh nice. I'll cherry-pick that change into our build and report back (probably after a while using - this error doesn't occur reliably)