metals
metals copied to clipboard
docs: Add a design doc for Language Support for notebook cells
It would be easier to read with rendered one :) https://github.com/scalameta/metals/blob/ccd1bed3a6eabe0d67d401be18ba348d1c494f3a/docs/design/language-support-notebook.md
Added a design document for https://github.com/scalameta/metals-feature-requests/issues/236 This document is for
- design review the architecture before going further
- make sure we are on the same page about the goal, design, and requirements for this feature
This PR is just for the design review. I opened a PR because it's easier to review (maybe we could write a design doc on Google Docs or something). Therefore, I don't need to merge this PR after people approved the architecture design, but this document could be useful as a log in the future.
Can you take a look, and give me some thoughts? @dos65 @tgodzik @alexarchambault (requesting review to someone who commented on the original feature requests).
Maybe you can skip until Problem
section because I guess you guys already know about the context.
@alexarchambault Hi, could you skim through this doc when you have time before I'm going further (to make sure we're on the same page about the implementation plan) I'm not in a rush (as I might not have time to work on this for several weeks), take you time :)
I'm only not sure if there is need in adding it to metals docs. Maybe it might be left in a issue comment to this feature request?
As @dos65 mentioned, we don't need to merge this PR (I just submit PR because it seems easier to review), I'll turn this into an issue and closing :)
https://github.com/scalameta/metals/issues/4434