metals-vscode icon indicating copy to clipboard operation
metals-vscode copied to clipboard

Add Filesystem API to jars

Open Arthurm1 opened this issue 3 years ago • 3 comments

Linked to https://github.com/scalameta/metals/pull/3750 and https://github.com/scalameta/metals-languageclient/pull/461

Arthurm1 avatar Apr 27 '22 19:04 Arthurm1

@kpodsiad Do you know how do fix the ESLint errors here? I'm trying to implement an interface method but I don't need the parameters - hence they're unused. I thought prefixing with _ caused the errors to be ignored but that only works with local compilation, not the github actions ESLint stage.

I've copied Microsoft's example method from here

Arthurm1 avatar Jun 11 '22 11:06 Arthurm1

@Arthurm1 you try different options that disable ESLint errors for unused params - https://eslint.org/docs/rules/no-unused-vars#varsignorepattern. varsIgnorePattern might be a could candidate - I used this to suppress errors for _ here

kpodsiad avatar Jun 11 '22 11:06 kpodsiad

@kpodsiad That works thanks!

Arthurm1 avatar Jun 11 '22 13:06 Arthurm1