mdoc icon indicating copy to clipboard operation
mdoc copied to clipboard

Update metaconfig, publish cli for Scala 3

Open keynmol opened this issue 4 years ago • 5 comments

  • Normalise location of dependency versions
  • Update metaconfig to 0.9.15 for all but Scala 2.11
  • Re-enable CLI cross-publishing for Scala 3

keynmol avatar Sep 27 '21 07:09 keynmol

@tgodzik I remember you mentioned something about scala 3 and pprint in mdoc..

I had to modify a few tests to make them work - not actually sure why, but can you confirm that what you were referring to was TPrint, not printing of values?

keynmol avatar Oct 05 '21 19:10 keynmol

We don't use pprint for Scala 3, that's because we didn't want to wait for the new versions to be released (it's not a problem now) and also Martin was using worksheets for Moocs, which he preferred to have normal toString for.

We could switch to pprint now, but it would probably be good to have a modifier for toString

tgodzik avatar Oct 05 '21 20:10 tgodzik

I think a modifier like no-pprint will be very welcome, by, say, FP folks.

That said, I can restore the old behaviour on Scala 3 - I'm just not sure how pprint was excluded before. I think Scala 2 and Scala 3 share the ReplVariablePrinter?

keynmol avatar Oct 05 '21 20:10 keynmol

It was a separate implementation classes called Printing in: https://github.com/scalameta/mdoc/blob/main/runtime/src/main/scala-3/mdoc/internal/document/Printing.scala

If I understand correctly what you are asking about 🤔

tgodzik avatar Oct 05 '21 20:10 tgodzik

I think a modifier like no-pprint will be very welcome, by, say, FP folks.

@keynmol there is a mdoc:to-string modifier that disables pprint https://scalameta.org/mdoc/docs/modifiers.html#to-string

olafurpg avatar Oct 20 '21 13:10 olafurpg