scastie icon indicating copy to clipboard operation
scastie copied to clipboard

add UI tests

Open MasseGuillaume opened this issue 8 years ago • 4 comments

https://github.com/japgolly/scalajs-react/blob/master/doc/TESTING.md

MasseGuillaume avatar Feb 25 '17 16:02 MasseGuillaume

I'll pick this one up next

arminio avatar Mar 05 '17 10:03 arminio

@MasseGuillaume am I only adding unit testing support to the client project for this? If yes, then this is done in this PR: https://github.com/scalacenter/scastie/pull/141

arminio avatar Mar 07 '17 19:03 arminio

Yeah good idea let's scope it only to the client project. It's where everything happens :) On Tue, 7 Mar 2017 at 20:03, Armin Keyvanloo [email protected] wrote:

@MasseGuillaume https://github.com/MasseGuillaume am I only adding unit testing support to the client project for this?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/scalacenter/scastie/issues/105#issuecomment-284822365, or mute the thread https://github.com/notifications/unsubscribe-auth/AA4Pkn_i4mcbk1BjVdWYR693KC-jPqr4ks5rjan6gaJpZM4MMECP .

-- -Gui

MasseGuillaume avatar Mar 07 '17 19:03 MasseGuillaume

Dear Future Implementor, have a look at the changes made in #202 for how to define a component so that it's easily unit testable. In this case, all you'd need for a TopBar unit test would be one instance of ReactTestVar and then easy, completely decoupled from AppState, AppBackend, etc.

japgolly avatar May 22 '17 00:05 japgolly