scalac-profiling icon indicating copy to clipboard operation
scalac-profiling copied to clipboard

Release for Scala 2.13

Open neko-kai opened this issue 6 years ago • 8 comments

Scala 2.13 is out! However it seems like this plugin only builds for 2.12 currently

neko-kai avatar Aug 16 '19 16:08 neko-kai

I took it upon me to provide a 2.13 version.

It is available here: https://gitlab.com/leonard.ehrenfried/scalac-profiling

It's a bit of a work in progress but the scalac plugin is working. I wanted to port the build to sbt 1 but failed at moving over the sbt plugin and the integration test suite. Perhaps one day I will do that too.

Feedback is welcome.

leonardehrenfried avatar Dec 02 '19 11:12 leonardehrenfried

@sjrd (is there perhaps someone at the Scala Center who has an interest in this...?)

SethTisue avatar Dec 02 '19 15:12 SethTisue

@leonardehrenfried Could you send a PR? I'm happy to review the PR :wink:

jvican avatar Dec 02 '19 16:12 jvican

The problem with my fork is that it's 2.13 only.

Also, I failed hard to understand the sbt 0.13 build and could not port it to 1.0. I also didn't want to downgrade to Java 8 so I could use sbt 0.13.

After having admitted defeat, I deleted the old build files and started a fresh sbt 1 build definition, which only compiles what I need: the scalac plugin for 2.13. What's missing are the integration tests and the sbt plugin.

The actual change to the plugin code is tiny (1 line).

So, I'm unsure how to proceed. I could just commit the change and pray that CI can build it.

Or we communally take care of moving the complete build to 1.0.

leonardehrenfried avatar Dec 02 '19 18:12 leonardehrenfried

it'd be great to have this resolved!

epifab avatar Dec 17 '19 19:12 epifab

@sjrd ping one more time.... I won't bother you again

SethTisue avatar Aug 19 '20 23:08 SethTisue

Thanks for the reminder @SethTisue. We should somehow make sure to provide a 2.13 version, yes. We're basically at full capacity these months for the release of Scala 3, so I don't think we'll be able to dedicate someone to this very soon, though. If someone submits a PR, I'll make sure to review and merge it.

I think the first step will be to look at what happened to the CI, and probably migrate it to GitHub Actions or something else that's hosted.

sjrd avatar Aug 20 '20 07:08 sjrd

PR: #32

SethTisue avatar Mar 01 '22 18:03 SethTisue

@danicheg I can reshare any publicity, if you point me to it

SethTisue avatar Oct 25 '23 15:10 SethTisue

@SethTisue I think the plan is the following:

  1. Ask some people from the community to try out the scalac-profiling in their projects. Not sure how loud this request should be.
  2. Once we gather feedback, and in case it's acceptable, we should polish some docs in this repo, plus, add some tweaks to the original article SPEEDING UP COMPILATION TIME WITH SCALAC-PROFILING (https://www.scala-lang.org/blog/2018/06/04/scalac-profiling.html).
  3. Publish the release and make press releases if we want to.

danicheg avatar Oct 25 '23 15:10 danicheg

Ask some people from the community to try out the scalac-profiling in their projects. Not sure how loud this request should be

feel free to announce it on #links on Discord, and if you put it on Mastodon or Twitter or Bluesky or whatever I will reshare

plus, add some tweaks to the original article

maybe just put a header at the top with a link to something that can be more easily kept up to date, e.g. the repo readme

SethTisue avatar Oct 25 '23 16:10 SethTisue

@danicheg I re-shared your Mastodon post, and I also tweeted https://twitter.com/SethTisue/status/1717244376399991116 and bluesky'ed https://bsky.app/profile/sethtisue.bsky.social/post/3kclu3snymc2r

SethTisue avatar Oct 25 '23 18:10 SethTisue

@SethTisue that's ... huge 😄 Hopefully, this will help someone.

danicheg avatar Oct 25 '23 18:10 danicheg

thank you so much for your effort and your patience on this.

SethTisue avatar Oct 25 '23 18:10 SethTisue