sbt-version-policy icon indicating copy to clipboard operation
sbt-version-policy copied to clipboard

False positive dependency error when upgrading to Scala 2.13.15 from 2.13.14

Open durban opened this issue 1 year ago • 4 comments

When upgrading a cross-built project from Scala 2.13.14 to 2.13.15, there are some dependency errors reported by versionPolicyReportDependencyIssues. See for example here: https://github.com/durban/choam/actions/runs/11059425885/job/30727717814#step:24:4147

[error] Incompatibilities with dependencies of choam-skiplist:0.4.0
[error]   org.scala-js:scalajs-scalalib_2.13: incompatible version change from 2.13.14+1.16.0 to 2.13.15+1.16.0 (compatibility: strict semantic versioning)
[error] Incompatibilities with dependencies of choam-skiplist:0.4.1
[error]   org.scala-js:scalajs-scalalib_2.13: incompatible version change from 2.13.14+1.16.0 to 2.13.15+1.16.0 (compatibility: strict semantic versioning)

The error seems to be caused by org.scala-js:scalajs-scalalib_2.13, whose version is updated from 2.13.14+1.16.0 to 2.13.15+1.16.0. I believe this error is a false positive, as it's supposed to be backward compatible.

durban avatar Oct 05 '24 15:10 durban

Thank you @durban for reporting the issue. @sjrd Could you please explain the versioning of Scala.js?

julienrf avatar Oct 06 '24 06:10 julienrf

I think this is the best explanation: https://github.com/scala-js/scala-js/pull/4913#issuecomment-1806257781

sjrd avatar Oct 06 '24 09:10 sjrd

Thank you for the pointer. What would you recommend to do in sbt-version-policy?

julienrf avatar Oct 06 '24 11:10 julienrf

This should be considered a compatible change, in this case.

That said, it may not be true for all libraries that have a version looking like that, so... I don't know what's best in general.

sjrd avatar Oct 06 '24 13:10 sjrd