webknossos icon indicating copy to clipboard operation
webknossos copied to clipboard

Fix loading of the first LOD mesh

Open daniel-wer opened this issue 1 year ago • 3 comments

The LOD loading order for the first loaded mesh always defaulted to 0, 1, 2, ... even if the actual LOD was 2 for example. This led to the mesh repeatedly disappearing: First LOD 0 was loaded, the mesh disappeared, LOD 1 was loaded, the mesh disappeared, LOD 2 was loaded.

URL of deployed dev instance (used for testing):

  • https://fixfirstlodmeshloading.webknossos.xyz

Steps to test:

  • @philippotto Do you happen to have a mesh file with LODs available for testing?

(Please delete unneeded items, merge only when none are left open)

  • [ ] Updated changelog
  • [x] Removed dev-only changes like prints and application.conf edits
  • [ ] Considered common edge cases

daniel-wer avatar Mar 27 '24 13:03 daniel-wer

  • @philippotto Do you happen to have a mesh file with LODs available for testing?

Probably not :thinking: Would probably be good to have one on the dev instances, right? Can you add one?

philippotto avatar Mar 27 '24 13:03 philippotto

@daniel-wer I see that you prepared a dev instance now. This means I can test there? I'm currently on spotty wifi, but already wanted to clarify this :)

philippotto avatar Apr 08 '24 13:04 philippotto

@daniel-wer I see that you prepared a dev instance now. This means I can test there? I'm currently on spotty wifi, but already wanted to clarify this :)

Yes you can test now. During my quick test, I wasn't able to reproduce the original issue (the flickering) on master, although the lod order was wrong (which I confirmed using the debugger) :thinking: Then, when testing this branch, the lod order was correct, but I sometimes saw some flickering :see_no_evil: I'll try to do another test today. If you test as well, not again that only the first loaded mesh is affected by the original bug.

daniel-wer avatar Apr 08 '24 14:04 daniel-wer