webknossos icon indicating copy to clipboard operation
webknossos copied to clipboard

New worker job: Find Largest Segment ID

Open fm3 opened this issue 2 years ago • 3 comments

wk side for https://github.com/scalableminds/webknossos-worker/pull/114

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Edit a dataset. Should look like this (if the largest segment id is empty): image

  • Click the Detect button image image

  • Should show a toast: image

  • After reloading: image (the message would typically be something like Updated largest segment id from 1 to 1470623.)

It would be even better if the largest segment id was automatically updated in the form, but for long running jobs this wouldn't really matter (as one can close the tab) and the interface of the API doesn't really lend itself to that currently.

Issues:

  • follow-up for #6039

(Please delete unneeded items, merge only when none are left open)

  • [x] Updated (unreleased) changelog
  • [ ] Updated (unreleased) migration guide if applicable
  • [ ] Updated documentation if applicable
  • [ ] Adapted wk-connect if datastore API changes
  • [ ] Adapted wk-libs python client if relevant API parts change
  • [ ] Needs datastore update after deployment
  • [X] Ready for review

fm3 avatar Aug 19 '22 10:08 fm3

@philippotto I adapted the job list view so that it displays the returned result message in the actions column. I’m aware that it does not really fit the column title but I don’t think creating a new column is worth it here. What do you think? Also, where do you think would be a good place for a button to trigger this job? Maybe you could have a look at the front-end part here?

fm3 avatar Sep 29 '22 08:09 fm3

I added some prototypical code to trigger the job (mainly so that I could test the worker). however, for a proper integration, I'd like to wait until #6485 is merged.

philippotto avatar Oct 07 '22 07:10 philippotto

cc @fm3 the frontend is ready for review. you might want to request a review for the backend, too :)

philippotto avatar Oct 26 '22 12:10 philippotto

Does the backend still need a review @fm3? If not, feel free to approve (auto-merge is enabled).

daniel-wer avatar Nov 01 '22 09:11 daniel-wer

I can’t approve my own PR but I’d say if philipp tested that the backend passes the parameters through so that the job runs as expected, the backend does not need further review :) :shipit:

fm3 avatar Nov 01 '22 09:11 fm3

I did not look at the front-end code in deatil, but one question just to make sure: is this disabled if jobs are not enabled for the instance and the dataset? (I’m asking with https://github.com/scalableminds/webknossos/issues/6582 in mind)

fm3 avatar Nov 01 '22 10:11 fm3