webknossos icon indicating copy to clipboard operation
webknossos copied to clipboard

Datastore/tracingstore health check fails sometimes

Open philippotto opened this issue 2 years ago • 1 comments

The frontend uses getDataStoreBuildInfo() even for the tracing store (see https://github.com/scalableminds/webknossos/blob/1ad2186b3dc7afc983fca3e9fef7adf897c5705e/frontend/javascripts/admin/datastore_health_check.ts#L40-L40), which returns a different structure (won't have datastoreApiVersion).

Also see https://github.com/scalableminds/webknossos-connect/issues/128 which is tangentially related.

philippotto avatar Apr 28 '22 12:04 philippotto

The PR descriptsion reads like the format is not what the frontend expects, but the title mentions sometimes it fails. Could you elaborate what the problem is here and what we should investigate?

fm3 avatar Sep 29 '22 12:09 fm3

I think, the "sometimes" simply referred to the fact that the healthcheck only fails under certain conditions (i.e., if tracingstore != datastore)?. I think, it should be easiest to doublecheck the return types of the different /api/buildinfo endpoints and compare that to https://github.com/scalableminds/webknossos/blob/master/frontend/javascripts/types/api_flow_types.ts#L515. The tracingstore's reply probably doesn't match the defined type. Then, the type (and the rest of the front-end) can be adapted accordingly.

philippotto avatar Nov 03 '22 13:11 philippotto

Airbrake: https://scm.airbrake.io/projects/95438/groups/3377135686729394283?tab=notice-detail

philippotto avatar Nov 07 '22 08:11 philippotto