webknossos
webknossos copied to clipboard
Datastore/tracingstore health check fails sometimes
The frontend uses getDataStoreBuildInfo()
even for the tracing store (see https://github.com/scalableminds/webknossos/blob/1ad2186b3dc7afc983fca3e9fef7adf897c5705e/frontend/javascripts/admin/datastore_health_check.ts#L40-L40), which returns a different structure (won't have datastoreApiVersion
).
Also see https://github.com/scalableminds/webknossos-connect/issues/128 which is tangentially related.
The PR descriptsion reads like the format is not what the frontend expects, but the title mentions sometimes it fails. Could you elaborate what the problem is here and what we should investigate?
I think, the "sometimes" simply referred to the fact that the healthcheck only fails under certain conditions (i.e., if tracingstore != datastore)?.
I think, it should be easiest to doublecheck the return types of the different /api/buildinfo
endpoints and compare that to https://github.com/scalableminds/webknossos/blob/master/frontend/javascripts/types/api_flow_types.ts#L515. The tracingstore's reply probably doesn't match the defined type. Then, the type (and the rest of the front-end) can be adapted accordingly.
Airbrake: https://scm.airbrake.io/projects/95438/groups/3377135686729394283?tab=notice-detail