Add missing version of `ValDef.let` which also accepts flags

Open Kalin-Rudnicki opened this issue 7 months ago • 1 comments

Seems like a pretty straight forward one.

Theres a version of this in Symbol.newVal which accepts flags
The function downstream of this accepts flags, and all other ValDef.let are just passing EmptyFlags by way of default arg

Jun 17 '25 22:06 Kalin-Rudnicki

Not sure what the correct way to add this is so that it doesnt fail that bincompat test. Could use some advisement on that

Jun 17 '25 23:06 Kalin-Rudnicki

@Kalin-Rudnicki @jchyb what is the status of this PR? should we try to get it in Scala 3.8.0? (otherwise it'd wait for 3.10)

Jul 23 '25 09:07 Gedochao

It just needs the changes pointed out in the comments above. I'll update this PR with them tomorrow. We should be able to squeeze it for 3.8.0

Jul 23 '25 10:07 jchyb

hey, sorry been crazy busy lately, @jchyb thanks for picking it up :)

Jul 23 '25 15:07 Kalin-Rudnicki

@Kalin-Rudnicki No worries, thank you for making the initial PR!

Jul 24 '25 14:07 jchyb

@jchyb should be good to merge, could you rebase?

Aug 04 '25 09:08 tgodzik