scala3 icon indicating copy to clipboard operation
scala3 copied to clipboard
verified publisher icon scala

Add warning for anonymous inline classes (#16723)

Open aherlihy opened this issue 1 year ago • 3 comments

Fixes #16723

aherlihy avatar Apr 29 '24 14:04 aherlihy

Can you also squash everything in a single commit

hamzaremmal avatar May 03 '24 13:05 hamzaremmal

@hamzaremmal Thank you for the review! Is there some strong preference for rebase merge over squash merge in the repo? Normally irrelevant commits and their messages will be removed upon squashing.

aherlihy avatar May 03 '24 15:05 aherlihy

@hamzaremmal Thank you for the review! Is there some strong preference for rebase merge over squash merge in the repo? Normally irrelevant commits and their messages will be removed upon squashing.

I agree, but this was a recommendation from @nicolasstucki to follow for this repository, maybe he can explain it here

hamzaremmal avatar May 03 '24 16:05 hamzaremmal