scala3 icon indicating copy to clipboard operation
scala3 copied to clipboard

Re-merge binary literals

Open Kordyjan opened this issue 1 year ago • 8 comments

Binary literals PR should be re-merged in time for 3.5 release.

https://github.com/lampepfl/dotty/pull/19405

Kordyjan avatar Feb 14 '24 16:02 Kordyjan

Why? I though they need a minor release?

odersky avatar Feb 14 '24 20:02 odersky

"before 3.5" is a bit ambiguous — presumably "in time for 3.5" was meant here.

SethTisue avatar Feb 14 '24 23:02 SethTisue

I updated the milestone in #19405 to 3.5 to avoid confusion.

nicolasstucki avatar Feb 15 '24 08:02 nicolasstucki

Ah indeed I misunderstood. So with the milestone added, can we close this issue now?

odersky avatar Feb 15 '24 09:02 odersky

Thinking more about it, shouldn't they be added as experimental first, validated by the SIP comittee, and only then merged as non-experimental ?

(I think it is fine to do an exception for this case, but it is good to be aware that this is what we are doing)

Sporarum avatar Feb 15 '24 13:02 Sporarum

That should be the procedure, but as far as I remember, there are problems with experimental switches during parsing.

Kordyjan avatar Feb 15 '24 14:02 Kordyjan

Not for language imports. We do honor them during parsing. But in this case, since the SIP is already accepted, we don't need to go though the procedure again.

odersky avatar Feb 15 '24 14:02 odersky

Out of curiosity, do we honor them as well during tokenization ?

(That is where the parsing of integer literals is done)

Sporarum avatar Feb 19 '24 13:02 Sporarum

It has been decided to be included in the 3.5.0 release.

Gedochao avatar Apr 03 '24 14:04 Gedochao